Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminal renderer and activeTerminal APIs #52143

Merged
merged 30 commits into from
Jun 18, 2018
Merged

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Jun 18, 2018

Fixes #46192
Fixes #47615

@Tyriar Tyriar added this to the June 2018 milestone Jun 18, 2018
@Tyriar Tyriar self-assigned this Jun 18, 2018
@Tyriar Tyriar merged commit 8d4466d into master Jun 18, 2018
@joaomoreno joaomoreno deleted the 46192_terminal_renderer branch June 28, 2018 13:24
@sgallouet
Copy link

would activeTerminal graduate to be part of the default release ? I'm using this proposed APIs since July and it seems to work great.

@Tyriar
Copy link
Member Author

Tyriar commented Sep 8, 2018

@sgallouet the main thing I'm waiting on is to be aware of consumers so we can make sure it's working well. Naturally I'm interested in your use case, can you link your extension?

@sgallouet
Copy link

@Tyriar I can't disclose much unfortunately, but simply put I'm using few terminal with different or same ssh connection and the extension do something like the "send to terminal" on my current active terminal which start some computation. it works pretty well.
is there an official channel to give proposed API feedback?

@Tyriar
Copy link
Member Author

Tyriar commented Sep 10, 2018

@sgallouet I don't think so, but I think I've heard enough for us to commit to the active terminal APIs. #58357

@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Track user focus across editor and integrated terminal Terminal Providers
2 participants