Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix config-context-key handling when config isn't known yet #239294

Merged
merged 1 commit into from
Jan 31, 2025
Merged

fix config-context-key handling when config isn't known yet #239294

merged 1 commit into from
Jan 31, 2025

Conversation

jrieken
Copy link
Member

@jrieken jrieken commented Jan 31, 2025

  • make sure to "read" when-clause of tools and agents as soon as registered
  • make sure to record config-context-keys that don't exist yet

@jrieken
fix config-context-key handling when config isn't known yet
2ce4d63 
* make sure to "read" when-clause of tools and agents as soon as registered
* make sure to record config-context-keys that don't exist yet
@jrieken jrieken self-assigned this Jan 31, 2025
@jrieken jrieken enabled auto-merge (squash) January 31, 2025 09:32
@jrieken jrieken requested a review from roblourens January 31, 2025 09:32
@jrieken jrieken added this to the January 2025 milestone Jan 31, 2025
@connor4312
Copy link
Member

Added the candidate marker since this is targeting 1.97

@connor4312 connor4312 added the candidate Issue identified as probable candidate for fixing in the next release label Jan 31, 2025
@roblourens roblourens self-assigned this Jan 31, 2025
@jrieken jrieken merged commit d231e6c into release/1.97 Jan 31, 2025
8 checks passed
@jrieken jrieken deleted the joh/fix239274 branch January 31, 2025 21:27
@roblourens
Copy link
Member

#239274

roblourens added a commit that referenced this pull request Feb 2, 2025
@roblourens
Revert "fix config-context-key handling when config isn't known yet (#…
99a5c74 
…239294)"

This reverts commit d231e6c.
roblourens added a commit that referenced this pull request Feb 3, 2025
@roblourens
Safer fix for 239274 (#239511)
14270fe 
* Revert "fix config-context-key handling when config isn't known yet (#239294)"

This reverts commit d231e6c.

* Ensure agentModeDisallowed key always changes when setting is registered
roblourens added a commit that referenced this pull request Feb 4, 2025
@roblourens
Safer fix for 239274 (#239511)
e68af2e 
* Revert "fix config-context-key handling when config isn't known yet (#239294)"

This reverts commit d231e6c.

* Ensure agentModeDisallowed key always changes when setting is registered
roblourens added a commit that referenced this pull request Feb 4, 2025
@roblourens
Ensure agent experiment defaults to not disabled (#239625)
a58d48f 
* Safer fix for 239274 (#239511)

* Revert "fix config-context-key handling when config isn't known yet (#239294)"

This reverts commit d231e6c.

* Ensure agentModeDisallowed key always changes when setting is registered

* Ensure defaults to not disabled
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@connor4312 connor4312 connor4312 approved these changes

@roblourens roblourens Awaiting requested review from roblourens

Assignees

@roblourens roblourens

@jrieken jrieken

Labels
candidate Issue identified as probable candidate for fixing in the next release
Projects
None yet
Milestone
January 2025
Development

Successfully merging this pull request may close these issues.
3 participants
@jrieken @connor4312 @roblourens