Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose comments input as text document #209512

Merged
merged 5 commits into from
Apr 5, 2024
Merged

Conversation

mjbvz
Copy link
Collaborator

@mjbvz mjbvz commented Apr 4, 2024

Fixes #209610
For #209508

Exposes comment input editors as text documents that extensions can see. Enables a few features in them too such as 'paste as' and 'drop into'

Will need polishing but this should get most of the basics working

Fixes https://github.com/microsoft/vscode-pull-request-github/issues/5875
For microsoft#209508

Exposes comment input editors as text documents that extensions can see. Enables a few features in them too such as 'paste as' and 'drop into'
@mjbvz mjbvz requested a review from alexr00 April 4, 2024 03:43
@mjbvz mjbvz self-assigned this Apr 4, 2024
Copy link
Member

@alexr00 alexr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome, thank you for making this change!

src/vs/base/common/network.ts Outdated Show resolved Hide resolved
mjbvz added a commit to mjbvz/vscode-spell-checker that referenced this pull request Apr 4, 2024
This enables spell check in VS Code's comment editors. Depends on microsoft/vscode#209512
Copy link
Member

@alexr00 alexr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@alexr00 alexr00 enabled auto-merge (squash) April 5, 2024 09:05
@alexr00 alexr00 merged commit 8cae0f0 into microsoft:main Apr 5, 2024
6 checks passed
@microsoft microsoft locked and limited conversation to collaborators Jun 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Cmd+V/Ctrl+V paste support for URLs turning them into Markdown links
3 participants