Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send Script Kind based on languageId for js and ts files #20351

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 4 additions & 9 deletions extensions/typescript/src/features/bufferSyncSupport.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
'use strict';

import * as cp from 'child_process';
import * as path from 'path';
import * as fs from 'fs';

import { workspace, window, TextDocument, TextDocumentChangeEvent, TextDocumentContentChangeEvent, Disposable, MessageItem } from 'vscode';
Expand Down Expand Up @@ -48,15 +47,11 @@ class SyncedBuffer {
fileContent: this.document.getText(),
};
if (this.client.apiVersion.has203Features()) {
// we have no extension. So check the mode and
// set the script kind accordningly.
const ext = path.extname(this.filepath);
if (ext === '') {
const scriptKind = Mode2ScriptKind[this.document.languageId];
if (scriptKind) {
args.scriptKindName = scriptKind;
}
const scriptKind = Mode2ScriptKind[this.document.languageId];
if (scriptKind) {
args.scriptKindName = scriptKind;
}

}
this.client.execute('open', args, false);
}
Expand Down