Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finalize env.onDidChangeShell #192886

Merged
merged 1 commit into from
Sep 12, 2023
Merged

Finalize env.onDidChangeShell #192886

merged 1 commit into from
Sep 12, 2023
+5 −18

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Sep 12, 2023 •
edited by jrieken
Loading

re #160694

@Tyriar Tyriar added this to the September 2023 milestone Sep 12, 2023
@Tyriar Tyriar self-assigned this Sep 12, 2023
@jrieken
Copy link
Member

jrieken commented Sep 12, 2023

fyi - changed the description so that this doesn't close the underlying issue of env.shell being empty at start

@Tyriar
Copy link
Member Author

Tyriar commented Sep 12, 2023

@jrieken tracking that in #190974 which is on the milestone and should get explicit verification as it's separate (also it'll still auto close since it's in the commit).

@Tyriar Tyriar merged commit 7ea4979 into main Sep 12, 2023
@Tyriar Tyriar deleted the tyriar/160694 branch September 12, 2023 16:00
lins0621 pushed a commit to lins0621/vscode that referenced this pull request Sep 14, 2023
@Tyriar @lins0621
Merge pull request microsoft#192886 from microsoft/tyriar/160694
115dc78 
Finalize env.onDidChangeShell
@github-actions github-actions bot locked and limited conversation to collaborators Oct 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jrieken jrieken jrieken approved these changes

Assignees

@Tyriar Tyriar

Labels
None yet
Projects
None yet
Milestone
September 2023
Development

Successfully merging this pull request may close these issues.
2 participants
@Tyriar @jrieken