Allow codeActionsOnSave to trigger for autoSave

[justschen]

Addresses #163920

Removing the code block check allows codeActionsOnSave and createCodeActionsOnSave to run on auto save.

Works for all autoSave settings including afterDelay, onFocusChange, and onWindowChange

(Main change was commenting out the check, other changes with the imports at the top are just a result of the autoSave running organize imports on the imports in that file when the setting for "editor.codeActionsOnSave": { "source.organizeImports": true } is on. )

[justschen]

Requesting @mattbierner since you worked on this last - if there's a better way to do this, I can give it a deeper look 👍

[mjbvz]

See #155059 for a discussion around this. I'm concerned that users will accidentally enable it and then be confused by the behavior (such as unused imports getting silently removed after a delay)

Instead of enabling this by default, maybe we could need an additional setting just for code actions that should be run on autosave, or something like:

"editor.codeActionsOnSave": {
    "source.fixAll": { "onAutosave": true}
  }

AFAIK we also don't support running format on autosave. Maybe we could look into enabling that too in a consistent way

[justschen]

Format on auto save seems to be diff from code actions since i know editor.formatOnSave exists.

but here's a working demo of what this looks like in the settings file!

(in the example, I hit ctrl + s, but still works with auto save on delay/focus change/etc)

[justschen]

There's a weird issue with applyOnSaveActions where even if there are things in excludedActions, it will still run the action on save because it's also in codeActionsOnSave. To eliminate that, I added filters that remove them from the final function call to applyOnSaveActions.

[justschen]

Added the following to match notebook code actions on save settings UI

[mjbvz]

Instead of handling the boolean values below, can you add logic here that converts the old boolean settings to the new enum values: false -> "never", true -> "explict". That should simplify the logic

[justschen]

tagging @Yoyokrazy for updates (pushed the code we wrote to this PR)

[wisscot]

Great work, thanks for the fix! Just curious will this go into next release? @justschen

[justschen]

@wisscot yes! migrating over from booleans to enums as well in #194345

Keep in mind, a change from this PR is that currently, always only works for cases of explicit save, focus_change autosave and window_change autosave. Code Actions on Auto Save after Delay isn't being supported.

[wisscot]

awesome, thanks for the heads up!