Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normallize drive letter to upper case when convert uri to FsPath, fix #155883 #156781

Closed
wants to merge 1 commit into from
Closed

Normallize drive letter to upper case when convert uri to FsPath, fix #155883 #156781

wants to merge 1 commit into from

Conversation

Danielmelody
Copy link

No description provided.

@Danielmelody Danielmelody force-pushed the normalize-uri-drive-letter branch from 16124ca to 17b9949 Compare August 1, 2022 08:52
@ghost
Copy link

ghost commented Aug 1, 2022 •
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

@Danielmelody Danielmelody force-pushed the normalize-uri-drive-letter branch from 17b9949 to 140b1f6 Compare August 1, 2022 16:24
@Danielmelody Danielmelody mentioned this pull request Aug 2, 2022
Merged
@lszomoru lszomoru assigned bpasero and jrieken and unassigned lszomoru Dec 6, 2022
@jrieken
Copy link
Member

jrieken commented Dec 6, 2022

Thanks for your contribution. Unfortunately we cannot accept changes to the fsPath-property. Many extension make assumptions about its casing and both variants are correct. We have picked one, which admittedly is the less popular one. However, we aren't going to cause a stir by changing it

@jrieken jrieken closed this Dec 6, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jan 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@bpasero bpasero

@jrieken jrieken

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Danielmelody @jrieken @bpasero @lszomoru