Remove duplicate declarations in terminal #153280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-stewart
commented
Jun 27, 2022
| @@ -181,11 +181,6 @@ export enum TitleEventSource { | |||
| export type ITerminalsLayoutInfo = IRawTerminalsLayoutInfo<IPtyHostAttachTarget | null>; | |||
| export type ITerminalsLayoutInfoById = IRawTerminalsLayoutInfo<number>; | |||
|
|
|||
| export interface IRawTerminalInstanceLayoutInfo<T> { | |||
There was a problem hiding this comment.
See line 137 for the duplicate definition.
a-stewart
commented
Jun 27, 2022
| @@ -454,11 +454,6 @@ export interface IStartExtensionTerminalRequest { | |||
| callback: (error: ITerminalLaunchError | undefined) => void; | |||
| } | |||
|
|
|||
| export interface IDefaultShellAndArgsRequest { | |||
| useAutomationShell: boolean; | |||
There was a problem hiding this comment.
See line 361 for duplicate definition.
meganrogge
approved these changes
Jun 27, 2022
|
✅ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #153279
Interfaces
IRawTerminalInstanceLayoutInfoin platform/terminal/common/terminal.ts andIDefaultShellAndArgsRequestin workbench/contrib/terminal/common/terminal.ts are defined twice with exactly the same definition.This PR removes one of each duplicate definitions.