Better handling of text/uri-list in built-in extensions #153163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- When splitting `text/uri-list`, we should split on `\n` to handle against spec versions of `text/uri-list` - However when constructing a `text/uri-list`, we should use `\r\n` to align with the spec
|
Could there be a problem from the split items ending in |
|
URI.parse ignores those but I can make it more explicit |
joyceerhl
approved these changes
Jun 24, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
text/uri-list, we should split on\nto handle against spec versions oftext/uri-list(i.e. strings that use\ninstead of\r\n)text/uri-list, we should use\r\nto align with the spec