debug: improve step in target UI #152131
Merged
debug: improve step in target UI #152131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is based on the DAP proposal here, which we should ratify before merging this: microsoft/debug-adapter-protocol#274 This PR changes the context menu action to try to step into the target at the cursor position, if there's a step target with a range at that position. Otherwise, it opens the context menu as it did before. Additionally, it adds a **Debug: Step Into Target** command which, when called (e.g. on keybinding) will show step targets for the current frame and allow the user to choose one.
|
Killer feature for me would be to have a way to |
roblourens
previously approved these changes
Jun 15, 2022
mjbvz
approved these changes
Jun 24, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on the DAP proposal here, which we should ratify before
merging this: microsoft/debug-adapter-protocol#274
This PR changes the context menu action to try to step into the target
at the cursor position, if there's a step target with a range at that
position. Otherwise, it opens the context menu as it did before.
Additionally, it adds a Debug: Step Into Target command which, when
called (e.g. on keybinding) will show step targets for the current
frame and allow the user to choose one.
See the #ux channel for a video of what this looks like.
Fixes #149871