Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profile support for global storage #152045

Merged
merged 16 commits into from
Jun 15, 2022
Merged

Profile support for global storage #152045

merged 16 commits into from
Jun 15, 2022

Conversation

bpasero
Copy link
Member

@bpasero bpasero commented Jun 14, 2022

@sandy081 first cut, can you:

  • review (does not yet include desktop)
  • adopt your API changes for profile where possible
  • look at web using 1 index DB if profile same
  • adopt StorageScope.APPLICATION (do a fulltext search to find all locations)

@bpasero bpasero added this to the June 2022 milestone Jun 14, 2022
@bpasero bpasero changed the title storage - first cut profile support Profile support for global storage Jun 14, 2022
@sandy081 sandy081 self-requested a review June 14, 2022 11:57
@sandy081 sandy081 added the user-profiles User profile management label Jun 15, 2022
@bpasero bpasero enabled auto-merge June 15, 2022 07:25
Copy link
Member

@sandy081 sandy081 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviwed and tested.
I will adopt application storage after.

@bpasero bpasero merged commit 4192006 into main Jun 15, 2022
@bpasero bpasero deleted the ben/151490 branch June 15, 2022 07:49
justschen pushed a commit to justschen/vscode that referenced this pull request Jun 16, 2022
justschen pushed a commit to justschen/vscode that referenced this pull request Jun 16, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jul 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
user-profiles User profile management
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants