Add more sanitization around the attributes in MD generated HTML #149100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjbvz
requested changes
May 16, 2022
| @@ -108,13 +108,13 @@ export function renderMarkdown(markdown: IMarkdownString, options: MarkdownRende | |||
| let attributes: string[] = []; | |||
| if (href) { | |||
| ({ href, dimensions } = parseHrefAndDimensions(href)); | |||
| attributes.push(`src="${href}"`); | |||
| attributes.push(`src="${href.replace(/"/g, '"')}"`); | |||
There was a problem hiding this comment.
This should likely be extracted to its own function instead of repeated
mjbvz
approved these changes
Jun 10, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When generating a link, we URL encode the value passed in as the href value.
We don't need to do it quite to aggressively elsewhere, but it would be good to add a bit of extra protection against html code being injected here.