Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to hide title bar when not showing menu bar #141847

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

DorianRudolph
Copy link

@DorianRudolph DorianRudolph commented Jan 30, 2022

This PR fixes #43154 by adding an option to hide the custom title bar when it is not needed to display the menu bar (i.e., for "toggle" and "compact" visibility settings).

The use case is Linux with tiling window manager (sway for me). Sway and other tiling window managers can draw their own title bars as seen below.

VSCode without title bar

The functionality of this PR is similar to #117149, though it is not concerned with zen mode.

@ghost
Copy link

ghost commented Jan 30, 2022

CLA assistant check
All CLA requirements met.

@sbatten
Copy link
Member

sbatten commented Jan 31, 2022

@DorianRudolph Why would one use the custom titlebar option only to draw a native titlebar?

@DorianRudolph
Copy link
Author

DorianRudolph commented Jan 31, 2022

Sorry if my explanation regarding tiling window managers was unclear.
Here is how my screen layout looks while working:

image

The small title/tab bars above the windows belong to the tiling window manager sway. They are unrelated to this PR and can also be disabled:

image

In the above screenshot you can compare VSCode with the title bar on the right vs. without on the left.

Without the title bar, I can get about 2 extra lines of code on screen, which on a smaller laptop can be significant.

VSCode with the native title bar enabled looks as follows:

image

But the native title bar has two downsides for me.
First, this displays the menu bar and context menu using GTK (following the OS theme), not directly in VSCode. If find the latter looks nicer and more coherent.
Second, now I don't have the option to hide the menu bar and use the toggle/compact menu bar settings.

@CleoMenezesJr
Copy link

Too bad this Merge was blocked. I don't understand why the problem of giving options to the user when it is deliberately possible.

@Titaniumtown
Copy link

Titaniumtown commented Mar 21, 2022

Yea. sucks, this would be a very good feature :(

@robsontenorio
Copy link

Maybe some plugin can solve it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Titlebar-less view for Linux
5 participants