Inline the toolbar for macOS

[orta]

Moves the traffic buttons on the window into the space above the activity bar on macOS - for full context see #12377

---

TODO:

• Wrap up the config setting
• migrate all CSS to be scoped by .use-inline-toolbar

fixes #12377

[msftclas]

Hi @orta, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

[coveralls]

Coverage increased (+0.002%) to 61.217% when pulling 764ecbd91332b38b90948ba39f72bb5dd6282488 on orta:mac-titlebar-inline into a1e908b on Microsoft:master.

[coveralls]

Coverage increased (+0.002%) to 61.217% when pulling 764ecbd91332b38b90948ba39f72bb5dd6282488 on orta:mac-titlebar-inline into a1e908b on Microsoft:master.

[orta]

When False

When true

Note: The setup script is async, so the activitybar kinda pop into the correct position, this would not happen once the system defaults to inline

[orta]

I've also signed the CLA just now

[bpasero]

@orta can you share how it would behave with sidebar hidden?

[orta]

With the sidebar hidden, there shouldn't be any behaviour changes

• you can still drag it back out of the edge by the activity bar
• Layout works fine, as it the workspace looks at the width of the elements at runtime

[orta]

Hrm, it does look like my method of triggering the re-layout adds the sidebar back when you go to full screen though. Will look at that now.

[bpasero]

@orta right. I see you are pushing down the tabs to make room for moving the window above?

Btw please keep in mind that there is also a mode where tabs are disabled and we in the team are actually mostly running with tabs === off.

[orta]

Oh, perfect, in that mode the entire thing can be draggable too 👍 -

Assuming you mean workbench.editor.showTabs, I've re-aligned the vertical spacing on text for them and allowed the entire tab to become a drag target, meaning you get the entire top bar as being a drag target

[orta]

I'm assuming the CLA bot isn't happy ( I used my personal email address - not my gh one ) - DocuSign Envelope ID: 6F1C856A-21F3-4532-9F03-F7252777488B

I can also put up the PDF too, if needs be

[bpasero]

@orta sucks about the CLA. @chrisdias @seanmcbreen can you help how to get the green badge?

[orta]

No worries, test fails are legit, will take a look

[coveralls]

Coverage remained the same at 61.22% when pulling 9a1eb27843e2716f1bbb735e8c2f48e620399ec1 on orta:mac-titlebar-inline into c844c65 on Microsoft:master.

[msftclas]

Hi @orta, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by Microsoft and real humans are currently evaluating your PR.

TTYL, MSBOT;

[bpasero]

Pushed changes to:

• shrink the activity bar when entering full screen mode
• use -webkit-app-region: no-drag; for actions to not drag by accident

Outstanding issues:

• badges look off
  
• what to do when activity bar is hidden
  
• what to do when sidebar is hidden or activity bar is on the right hand side
  

[octref]

Maybe hide the traffic light too for people who hide activity bar?

If people are keyboard-driven to the extent of not clicking activity bar icons, I guess they never use traffic light anyway.

Still, right side activity bar is a problem.

[bpasero]

@octref as far as i know you cannot hide the window buttons on Mac.

[octref]

@bpasero You can do that with https://github.com/electron/electron/blob/master/docs/api/frameless-window.md#create-a-frameless-window

By flipping this bit on src/vs/code/electron-main:

[bpasero]

True, good point 👍

[orta]

Sorry, been getting married, honeymoon’d and then at conferences this last
week!

Really happy to have you wrapping this up, you know so much more than me
about all the different contexts. Especially as the changes are new - hack
away :D

--
[·/ ] Orta Therox

w/ Artsy http://artsy.net/
CocoaPods http://cocoapods.org/ / CocoaDocs http://cocoadocs.org/
@orta / orta.github.com
Artsy is totally hiring iOS Devs http://artsy.net/job/developer ATM

On Fri, Nov 11, 2016 at 6:24 AM, Benjamin Pasero notifications@github.com
wrote:

True, good point 👍

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#12628 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAC_jtuak-kp-N9dZGMOTKh370m613Dwks5q8_wBgaJpZM4KGdMs
.

[dilijev]

@octref for what it's worth I'm very keyboard-driven and use hotkeys for nearly everything, but I'd be more likely to toggle visibility of the sidebar with a hotkey because the functionality it exposes is for the most part UI-driven or uncommon enough that it's not worth memorizing hotkeys.

Also maybe I'm weird I still use the title bar to close windows most of the time.

[octref]

@orta Still, thank you a lot for your incredible contribution so far. I'll pick it up and hopefully get it into the next release.

@dilijev Input taken. Thanks.

[octref]

Finally settled down. I'm thinking about bringing this forward during endgame when master isn't moving fast.

@bpasero This time I'd like to get a concrete design before starting the work, so I won't waste time and go the wrong direction.
Do you mind discussing with UX team in this week's meeting and let me know how you would like this to be done?
My current thinking is, we have 3 mode for the titleBarStyle.

• default: what we currently have.
• inline: what @orta has here. Except we always show sidebar on left side. Toggle sidebar and changing sidebar to right will be disabled.
• hidden: hide the titlebar and traffic light altogether. Give a bit space on top of tab, similar to inline. User could still toggle/move sidebar.

In the long term, we can evolve inline to make a custom inline titlebar for each OS, aligning to its design guidelines. For example, @be5invis's proposal for Windows #12377 (comment)

[bpasero]

Please ping me again in 1 week, we are in endgame and I will not have time for this issue during the week 👍

[tal]

@bpasero I'd actually love to see this myself. so I'll ping on their behalf :P

[bpasero]

@octref maybe better to move the discussion out into a new UX issue so that we can have it separate from the implementation issue. if you can add mockups for your proposals, that would probably be most helpful.

[octref]

Hey @orta can you add me as a collaborator to your fork? Let's bring it on par with master first...

[octref]

@bpasero See #17532

[orta]

@octref 👍

[bpasero]

Closing this PR until there is activity again.

[ShalokShalom]

inline: what @orta has here. Except we always show sidebar on left side. Toggle sidebar and changing sidebar to right will be disabled.

Maybe interact with a solution that puts the traffic lights to the right side in order to enable the inline mode also once the activity sidebar is there? 🙂