Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to hide title bar in Zen Mode (even outside full screen mode) #117136

Closed

Conversation

W4RH4WK
Copy link
Contributor

@W4RH4WK W4RH4WK commented Feb 20, 2021

This PR is related to #33607.

This PR fixes #115570.

Please revisit the config option description. I don't know whether my wording is appropriate here.

@ghost
Copy link

ghost commented Feb 20, 2021

CLA assistant check
All CLA requirements met.

@W4RH4WK
Copy link
Contributor Author

W4RH4WK commented Feb 20, 2021

Realized that with this implementation the menu bar cannot be toggled correctly anymore. Will try to fix and re-open this.

@W4RH4WK W4RH4WK closed this Feb 20, 2021
@W4RH4WK
Copy link
Contributor Author

W4RH4WK commented Feb 20, 2021

After investigating the menu bar issue, I don't think this can be implemented fully without adding additional flags to other components.

It works fine when window.menuBarVisibility set to toggle, but currently not for `classic. This happens because the menu bar focus / unfocus logic cannot query whether Zen Mode is currently active or not.

} else if (this.options.visibility === 'classic' && browser.isFullscreen()) {

Furthermore, during debugging I discovered that some functions in layout.ts related to the menu bar might be dead code, namely getMenubarVisibility and toggleMenuBar.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to hide titlebar in Zen mode without fullscreen
1 participant