Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New issue editor not restored correctly #99040

Closed
jrieken opened this issue Jun 2, 2020 · 5 comments · Fixed by microsoft/vscode-pull-request-github#1842
Closed

New issue editor not restored correctly #99040

jrieken opened this issue Jun 2, 2020 · 5 comments · Fixed by microsoft/vscode-pull-request-github#1842
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone

Comments

@jrieken
Copy link
Member

jrieken commented Jun 2, 2020

Testing #98019

  • open and pin vscode.d.ts, vscode.proposed.d.ts, and NewIssue.md, open another file
  • reload window
  • select the 'N' editor
  • an error about a missing file system provider happens (not sure if that's because of a missing activation event or because the event isn't fired)
@alexr00
Copy link
Member

alexr00 commented Jun 2, 2020

It looks like the file system provider is just registered too late in the extension. The extension already *-activates, but I can also add an onFileSystem activation if the editor looks for that. I'll also move the registration up.

@alexr00 alexr00 added the bug Issue identified by VS Code Team member as probable bug label Jun 2, 2020
@alexr00 alexr00 added this to the May 2020 milestone Jun 2, 2020
@bpasero
Copy link
Member

bpasero commented Jun 2, 2020

@alexr00 can you check if this reproduces independently from the editor being pinned, I would not expect that to have any impact.

@alexr00
Copy link
Member

alexr00 commented Jun 2, 2020

It is independent of pinning.

@jrieken jrieken changed the title Pinned new issue editor not restored corrected Pinned new issue editor not restored correctly Jun 2, 2020
@bpasero bpasero removed their assignment Jun 2, 2020
@bpasero bpasero changed the title Pinned new issue editor not restored correctly New issue editor not restored correctly Jun 2, 2020
alexr00 added a commit to microsoft/vscode-pull-request-github that referenced this issue Jun 3, 2020
Needs to be earlier to prevent errors.
Fixes microsoft/vscode#99040
@lramos15 lramos15 added verified Verification succeeded verification-found Issue verification failed and removed verified Verification succeeded labels Jun 4, 2020
@lramos15
Copy link
Member

lramos15 commented Jun 4, 2020

There's no longer an error, but newIssue.md is blank after reloading the window. I'm not sure what the expected behavior is. I'm going to reopen this for now as I would still classify that as not restoring correctly, but feel free to close this if this was intended.

@lramos15 lramos15 reopened this Jun 4, 2020
@alexr00
Copy link
Member

alexr00 commented Jun 5, 2020

It's intended, as the state of the repo may have changed since the file was created in VS Code.

@alexr00 alexr00 closed this as completed Jun 5, 2020
@alexr00 alexr00 added verified Verification succeeded and removed verification-found Issue verification failed labels Jun 5, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jul 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants