Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revisit OS X fonts #9055

Closed
joaomoreno opened this issue Jul 11, 2016 · 2 comments
Closed

Revisit OS X fonts #9055

joaomoreno opened this issue Jul 11, 2016 · 2 comments
Assignees
@weinand
Labels
bug Issue identified by VS Code Team member as probable bug macos Issues with VS Code on MAC/OS X ux User experience issues verified Verification succeeded
Milestone
July 2016

Comments

@joaomoreno
Copy link
Member

joaomoreno commented Jul 11, 2016 •
edited
Loading

@fitojb says of 50d96e2

The Display variant of the SF typeface should not be used for small UI copy, as it is simply too thin. Please use the Text variant instead: .SFNSText-Light. And then, I'm not sure why pick the Light weight over Regular...
@joaomoreno joaomoreno added the ux User experience issues label Jul 11, 2016
@joaomoreno joaomoreno added this to the July 2016 milestone Jul 11, 2016
@joaomoreno joaomoreno assigned joaomoreno and unassigned joaomoreno Jul 11, 2016
@joaomoreno
Copy link
Member Author

Verifier reference:

@joaomoreno joaomoreno added the bug Issue identified by VS Code Team member as probable bug label Jul 11, 2016
jrieken pushed a commit that referenced this issue Jul 12, 2016
@joaomoreno @jrieken
use better OS X default font
a486cf8 
fixes #9055
@joaomoreno joaomoreno mentioned this issue Jul 13, 2016
Closed
@Tyriar Tyriar added the macos Issues with VS Code on MAC/OS X label Jul 27, 2016
@aeschli
Copy link
Contributor

aeschli commented Jul 29, 2016

Verified that we now use the San Fransisco Text font.

@aeschli aeschli added the verified Verification succeeded label Jul 29, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@weinand weinand

Labels
bug Issue identified by VS Code Team member as probable bug macos Issues with VS Code on MAC/OS X ux User experience issues verified Verification succeeded
Projects
None yet
Milestone
July 2016
Development

No branches or pull requests
4 participants
@joaomoreno @weinand @Tyriar @aeschli