-
Notifications
You must be signed in to change notification settings - Fork 30.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minifier: remove hoist_funs: true configuration once it is safe #80202
Comments
I pushed a commit to improve the parse errors |
@aeschli where to? I can try to run a build with it |
Here is a build with Full output after your change:
|
Problem is in terser: Created terser/terser#445 |
Awesome. My feeling is to wait for the fix on Terser before changing this function back. |
Pushed. |
When we minify, we have to pass in
hoist_funs: true
, otherwise we get below results:Somehow our json parser stumbles over our language configurations otherwise. I have not fully figured out why that is, but this is something we should follow up.
To reproduce:
hoist_funs: true
inbuild/lib/optimize.ts
and change it tofalse
yarn gulp vscode-darwin-min
//cc @chrmarti
The text was updated successfully, but these errors were encountered: