Icon missing for data breakpoints

[weinand]

Testing #79799

Data breakpoints don't show an icon in the BREAKPOINTS view:

[isidorn]

@misolori and me were thinking if we should go with the standard red circle. Or be more creative and use something new like a red hexagon.
If we do not find something nice, I will just go with the red circle for this week.

@weinand let me know if you have some ideas.

[weinand]

I'm fine with everything that looks different than the shapes already in use.
E.g. a dodecahedron or any other Platonic solid works fine for me...

[miguelsolorio]

@isidorn @weinand here are a few options and the rest to compare. Complex 3d shapes are a lot harder to see at smaller sizes:

[weinand]

the "Platonic solids" was a joke... no 3D necessary.
I like Data 2

[isidorn]

Data 2 was what I imagined. And yes I really like it.
Since the other remind me of batman (I don't know why), the sun and the moon.

@misolori I will update the code and you can just push the icons to src/vs/workbench/contrib/debug/browser/media/
We need breakpoint-data.svg, breakpoint-data-disabled.svg and breakpoint-data-unverified.svg

[isidorn]

@misolori I have pushed the changes on the vscode side via 44fa853
We just need the three .svg files

[miguelsolorio]

These are now checked in:

[isidorn]

Fancy!

[weinand]

Verified that data breakpoint got an icon.

However, the visual difference between the new icon and the icon of source breakpoints is almost invisible at the default size:

Maybe a square icon would be a better choice.

[isidorn]

An issue with the square icon is that it looks like the stop sign.
I like this one but it needs to be thiner, so it looks less rounded.