Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editors: group not activated with workbench.editor.revealIfOpen: true #79798

Closed
bpasero opened this issue Aug 26, 2019 · 1 comment · Fixed by microsoft/azuredatastudio#7206
Closed
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented Aug 26, 2019

Steps to Reproduce:

  1. configure workbench.editor.revealIfOpen: true
  2. open multiple editor groups
  3. open some editors in one group and others in the other group
  4. focus the first editor group
  5. click on a file in the other group via explorer that is currently active in that other group

=> 🐛 there is no visual indicator that something happened because we do not activate that other group

A fix would be to always ensure we activate a group of the editor we want to open. The only one exception is when opening an editor to the side. For historic reasons we do not activate the editor group in that case if preserveFocus: true.

//cc @eamodio since you complained about this in #24717 it seems, but only limited to search. You should see this issue in all kinds of cases where we open an editor and I think this new behaviour is better, let me know otherwise.

@bpasero bpasero added the bug Issue identified by VS Code Team member as probable bug label Aug 26, 2019
@bpasero bpasero added this to the August 2019 milestone Aug 26, 2019
@bpasero bpasero self-assigned this Aug 26, 2019
bpasero added a commit that referenced this issue Aug 26, 2019
hunghw pushed a commit to hunghw/vscode that referenced this issue Aug 28, 2019
hunghw pushed a commit to hunghw/vscode that referenced this issue Aug 28, 2019
@sandy081 sandy081 added the verified Verification succeeded label Aug 29, 2019
@eamodio
Copy link
Contributor

eamodio commented Aug 31, 2019

@bpasero Looks good -- thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants