Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated Terminal.onDidWriteData extension API #78574

Closed
Tyriar opened this issue Aug 6, 2019 · 0 comments · Fixed by #80836
Closed

Remove deprecated Terminal.onDidWriteData extension API #78574

Tyriar opened this issue Aug 6, 2019 · 0 comments · Fixed by #80836
Assignees
@Tyriar
Labels
api api-proposal debt Code quality issues terminal General terminal issues that don't fall under another label
Milestone
September 2019

Comments

@Tyriar
Copy link
Member

Tyriar commented Aug 6, 2019

This proposed API is deprecated in favor of the global window.onDidWriteTerminalData event that will land in tomorrow's Insiders (#78502).

fyi @IlyaBiryukov @roblourens
@Tyriar Tyriar added api debt Code quality issues terminal General terminal issues that don't fall under another label api-proposal labels Aug 6, 2019
@Tyriar Tyriar added this to the September 2019 milestone Aug 6, 2019
@Tyriar Tyriar self-assigned this Aug 6, 2019
@Tyriar Tyriar mentioned this issue Aug 6, 2019
Closed
Tyriar added a commit to microsoft/vscode-extension-samples that referenced this issue Sep 13, 2019
@Tyriar
Use onDidWriteTerminalData
6400a0c 
Part of microsoft/vscode#78574
Tyriar added a commit that referenced this issue Sep 13, 2019
@Tyriar
Remove Terminal.onDidWriteData
678abfe 
Replaced by vscode.window.onDidWriteTerminalData

Fixes #78574
@Tyriar Tyriar mentioned this issue Sep 13, 2019
Merged
@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
api api-proposal debt Code quality issues terminal General terminal issues that don't fall under another label
Projects
None yet
Milestone
September 2019
Development

Successfully merging a pull request may close this issue.

Remove Terminal.onDidWriteData microsoft/vscode
1 participant
@Tyriar