Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect global .gitignore when searching #59364

Closed
vanossj opened this issue Sep 25, 2018 · 4 comments · Fixed by #59717
Closed

Respect global .gitignore when searching #59364

vanossj opened this issue Sep 25, 2018 · 4 comments · Fixed by #59717
Assignees
Labels
feature-request Request for new features or functionality good first issue Issues identified as good for first-time contributors help wanted Issues identified as good community contribution opportunities search Search widget and operation issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@vanossj
Copy link

vanossj commented Sep 25, 2018

The global .gitignore file, aka git config core.excludesfile setting should be used when searching, just like the local .gitignore file is.

Currently files/folders will be ignored if they are in the local .gitignore, but not if they are only in the global git ignore.

#49239 asked about this feature, but it was incorrectly closed.

@vscodebot
Copy link

vscodebot bot commented Sep 25, 2018

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@vscodebot vscodebot bot added the search Search widget and operation issues label Sep 25, 2018
@roblourens
Copy link
Member

I can add a setting to be opted into this, but I disabled it by default because it confused too many people

@roblourens roblourens added feature-request Request for new features or functionality help wanted Issues identified as good community contribution opportunities labels Sep 25, 2018
@roblourens
Copy link
Member

Would take a PR that adds a setting, false by default, for whether to add this flag: https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/services/search/node/ripgrepTextSearch.ts#L514

@roblourens roblourens added the good first issue Issues identified as good for first-time contributors label Sep 25, 2018
@skprabhanjan
Copy link
Contributor

skprabhanjan commented Sep 28, 2018

@roblourens , can i send a PR on this?
I have added a new config in the interface IRawSearch (https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/services/search/node/search.ts#L22) and used that while pushing it to args, but can you help me understand if by adding
ignoreGlobal?: boolean; , will it also make the default value as false?
Thanks :)

skprabhanjan pushed a commit to skprabhanjan/vscode that referenced this issue Oct 1, 2018
skprabhanjan pushed a commit to skprabhanjan/vscode that referenced this issue Oct 1, 2018
skprabhanjan pushed a commit to skprabhanjan/vscode that referenced this issue Oct 2, 2018
skprabhanjan pushed a commit to skprabhanjan/vscode that referenced this issue Oct 2, 2018
skprabhanjan pushed a commit to skprabhanjan/vscode that referenced this issue Oct 4, 2018
roblourens added a commit that referenced this issue Oct 4, 2018
Fix #59364 : Respect global .gitignore when searching
@roblourens roblourens added this to the October 2018 milestone Oct 31, 2018
@roblourens roblourens added the verification-needed Verification of issue is requested label Oct 31, 2018
@miguelsolorio miguelsolorio added the verified Verification succeeded label Nov 1, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality good first issue Issues identified as good for first-time contributors help wanted Issues identified as good community contribution opportunities search Search widget and operation issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants