Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu bar toggling is inconsistent with the rest of Windows #58377

Closed
akbyrd opened this issue Sep 10, 2018 · 7 comments
Closed

Menu bar toggling is inconsistent with the rest of Windows #58377

akbyrd opened this issue Sep 10, 2018 · 7 comments
Assignees
Labels
menus Menu items and widget issues upstream Issue identified as 'upstream' component related (exists outside of VS Code)

Comments

@akbyrd
Copy link
Contributor

akbyrd commented Sep 10, 2018

I'm splitting out some previously reported issues since they weren't resolved with the fix to the original issue.

There are a couple of quirks with the keybinding for toggling the menu bar that don't match other Windows applications and cause workflow annoyances. These both occur when window.menuBarVisibility is set to toggle.

  1. Hold Ctrl, press and release Alt, notice the menu bar is toggled.
    Expected: the menu bar is not toggled.
    I've tested with various other applications on Windows including Notepad, Paint, and Firefox. None of them do this.

  2. Press and release Alt, press escape, notice the menu bar does not get hidden.
    Expected: the menu bar should be hidden.
    I tested with Firefox and Visual Studio 2015 (using https://marketplace.visualstudio.com/items?itemName=MatthewJohnsonMSFT.HideMainMenu) and both will hide the menu bar when escape is pressed.

Issue 1 is a daily annoyance for me, as it seems to happen very frequently when I jump between editor groups.

Also, the new custom title bar doesn't have these issues and it feels like the menu bars should be consistent with each other and with the rest of the Windows experience.

@vscodebot
Copy link

vscodebot bot commented Sep 10, 2018

@sbatten sbatten added upstream Issue identified as 'upstream' component related (exists outside of VS Code) workbench-menu labels Sep 11, 2018
@sbatten
Copy link
Member

sbatten commented Sep 11, 2018

@akbyrd just to clarify, this issue is specific to the old style menu bar?

@sbatten sbatten added this to the Backlog milestone Sep 11, 2018
@akbyrd
Copy link
Contributor Author

akbyrd commented Sep 11, 2018

This only applies to the old menu bar.

@sbatten sbatten added menus Menu items and widget issues and removed workbench-menu labels Oct 7, 2019
@m50d
Copy link

m50d commented May 24, 2020

Assuming this is the same issue: when I use Alt-` (toggle Japanese input method) focus moves to the menu bar (as though I'd just tapped Alt). Extremely frustrating when trying to write text in mixed Japanese/English!

@AB1908
Copy link

AB1908 commented Jun 6, 2020

I'm having a somewhat similar issue but the relevant ones seem to have been locked.

  • System Information:
    • Environment: Linux x64 5.6.15-arch1-1
    • DE: GNOME 3.36.2
    • Display Server: X11
    • VS Code Version: 1.45.1
    • Commit: 5763d90
    • Date: 2020-05-14T08:27:22.494Z
    • Electron: 7.2.4
    • Chrome: 78.0.3904.130
    • Node.js: 12.8.1
    • V8: 7.8.279.23-electron.0
  • Extension Table:
Extension Author (truncated) Version
textile idl 0.1.5
latex-workshop Jam 8.10.0
textile-preview mic 1.0.2
python ms- 2020.5.80290
code-spell-checker str 1.9.0
vscode-icons vsc 10.1.1
vim vsc 1.14.5
  • Reproducible Steps:
    • Split terminal using Ctrl+Shift+%
    • Press Alt+Right Arrow to switch to terminal on right
  • Expected Behaviour: Cursor switches to terminal on the right followed by user actions such as input, etc.
  • Observed Behaviour: Cursor switches to terminal on right followed by Menu Bar becoming visible or focused depending on prior setting of Menu Visibility.
  • Notes: The behaviour is also observed when using any two keystroke command involving a leading Alt, such as any GNOME based shortcuts. It can also be observed by pressing Ctrl+Alt, which ideally should not lead to a capture of Alt.

@sbatten sbatten assigned deepak1556 and unassigned sbatten Oct 19, 2020
@sbatten
Copy link
Member

sbatten commented Oct 19, 2020

@deepak1556 this is an old issue about electron's menus

@deepak1556
Copy link
Collaborator

deepak1556 commented Dec 12, 2022

  1. from Menu bar toggling is inconsistent with the rest of Windows #58377 (comment) is addressed, 1) is still present. Closing as blocked on upstream and will not be actionable in the next few months.

@deepak1556 deepak1556 closed this as not planned Won't fix, can't repro, duplicate, stale Dec 12, 2022
@deepak1556 deepak1556 removed this from the Backlog milestone Dec 12, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jan 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
menus Menu items and widget issues upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Projects
None yet
Development

No branches or pull requests

5 participants