Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Subword navigation : Confusing keybinding name #53497

Closed
V-ed opened this issue Jul 3, 2018 · 1 comment · Fixed by #55492
Closed

Subword navigation : Confusing keybinding name #53497

V-ed opened this issue Jul 3, 2018 · 1 comment · Fixed by #55492
Assignees
@alexdima
Labels
bug Issue identified by VS Code Team member as probable bug editor-wordnav Editor word navigation issues verified Verification succeeded
Milestone
July 2018

Comments

@V-ed
Copy link
Contributor

V-ed commented Jul 3, 2018 •
edited
Loading

Issue type : Modification Request

After the PR #48023 has been merged, a feature I really like has been added to VSCode and is currently in Insiders. Thing is, there is two commands that confused me when I first read them :

vscode cursorWordPartStartLeft

cursorWordPartStartLeft and cursorWordPartStartLeftSelect

I propose a very slight modification to them : the word Start is rather confusing and should be removed. These two commands does the exact same behavior as cursorWordPartRight (but goes to the left), so I feel like they should be named the same way : cursorWordPartLeft and cursorWordPartLeftSelect.

VSCode Insiders Info 

  Version: 1.25.0-insider
  Commit: 33ba00346fd1bc889d5adc2f386c64fdb3657e61
  Date: 2018-07-03T14:40:32.630Z
  Electron: 1.7.12
  Chrome: 58.0.3029.110
  Node.js: 7.9.0
  V8: 5.8.283.38
  Architecture: x64

@alexdima alexdima added this to the July 2018 milestone Jul 4, 2018
@sdlins
Copy link

sdlins commented Jul 6, 2018

Same feeling. The names should keep the coherence.

@alexdima alexdima added editor-wordnav Editor word navigation issues bug Issue identified by VS Code Team member as probable bug labels Jul 27, 2018
@V-ed V-ed mentioned this issue Jul 31, 2018
Merged
alexdima added a commit that referenced this issue Aug 2, 2018
@alexdima
Merge pull request #55492 from V-ed/start-word-removal
c7b4951 
Remove confusing Start from wordPartLeft commands ID : #53497
@mjbvz mjbvz added the verified Verification succeeded label Aug 2, 2018
alexdima added a commit that referenced this issue Aug 2, 2018
@alexdima
Register previous ids for compatibility (#53497)
435955d
@vscodebot vscodebot bot locked and limited conversation to collaborators Sep 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexdima alexdima

Labels
bug Issue identified by VS Code Team member as probable bug editor-wordnav Editor word navigation issues verified Verification succeeded
Projects
None yet
Milestone
July 2018
Development

Successfully merging a pull request may close this issue.

Remove confusing Start from wordPartLeft commands ID : #53497
4 participants
@sdlins @alexdima @mjbvz @V-ed