Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Menu: Custom title menu should say Meta/Super instead of Windows on Linux #53002

Closed
Tyriar opened this issue Jun 26, 2018 · 4 comments · Fixed by #55061
Closed

Menu: Custom title menu should say Meta/Super instead of Windows on Linux #53002

Tyriar opened this issue Jun 26, 2018 · 4 comments · Fixed by #55061
Assignees
@Tyriar @alexdima @sbatten
Labels
bug Issue identified by VS Code Team member as probable bug debt Code quality issues linux Issues with VS Code on Linux verified Verification succeeded
Milestone
July 2018

Comments

@Tyriar
Copy link
Member

Tyriar commented Jun 26, 2018

#52854
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug linux Issues with VS Code on Linux titlebar VS Code main title bar issues labels Jun 26, 2018
@Tyriar Tyriar added workbench-menu and removed titlebar VS Code main title bar issues labels Jun 28, 2018
@sbatten sbatten added the debt Code quality issues label Jul 3, 2018
@bpasero
Copy link
Member

bpasero commented Jul 13, 2018

I am actually surprised this bug exists, @sbatten aren't you using some keybinding helper to turn the keybinding into a human readable label?

@sbatten
Copy link
Member

sbatten commented Jul 16, 2018

@bpasero yea I'm using the keybinding service, yes, I'm not doing anything special on my own I don't believe.

@Tyriar
Copy link
Member Author

Tyriar commented Jul 25, 2018

Related: #55060

@Tyriar Tyriar mentioned this issue Jul 25, 2018
Merged
@Tyriar
Copy link
Member Author

Tyriar commented Jul 25, 2018

PR out: #55061

@Tyriar Tyriar added this to the July 2018 milestone Jul 25, 2018
Tyriar added a commit that referenced this issue Jul 25, 2018
@Tyriar
Label Windows key as super on Linux
aa6dd3f 
Fixes #53002
@RMacfarlane RMacfarlane added the verified Verification succeeded label Aug 1, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Sep 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

@alexdima alexdima

@sbatten sbatten

Labels
bug Issue identified by VS Code Team member as probable bug debt Code quality issues linux Issues with VS Code on Linux verified Verification succeeded
Projects
None yet
Milestone
July 2018
Development

Successfully merging a pull request may close this issue.

Label Windows key as super on Linux microsoft/vscode
5 participants
@bpasero @Tyriar @RMacfarlane @alexdima @sbatten