Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using menuBarVisibility set to toggle and alt commands menu contributions. #37724

Closed
Krzysztof-Cieslak opened this issue Nov 6, 2017 · 4 comments
Assignees
Labels
info-needed Issue requires more information from poster

Comments

@Krzysztof-Cieslak
Copy link
Contributor

This is a small UX problem.

  • Setting menuBarVisibility to toggle means that top menu bar will be shown only after pressing the Alt button.
  • Extensions can define Alt commands for menu contributions to provide alternative commands that get enabled when user press Alt button.

Problem: user wants to use Alt command but it also additionally causes menuBar to toggle on, which causes the whole screen to jump a bit. And there is no way to override used key for any of those actions (at least as far as I know).

Possible solution:
Make buttons used in both cases configurable with normal keyboard settings.

@vscodebot vscodebot bot added the workbench label Nov 6, 2017
@bpasero bpasero added workbench-menu feature-request Request for new features or functionality and removed workbench labels Nov 16, 2017
@sandy081 sandy081 removed their assignment Dec 4, 2017
@bpasero
Copy link
Member

bpasero commented Mar 20, 2018

@Krzysztof-Cieslak wouldn't it make a lot more sense to recommend to these people to set menuBarVisibility to hidden instead?

Bottom line is that there is no way to configure the Alt key when menu is set to toggling (see also #41070)

@bpasero bpasero added info-needed Issue requires more information from poster and removed feature-request Request for new features or functionality workbench-menu labels Mar 20, 2018
@bpasero bpasero self-assigned this Mar 20, 2018
@lyallh
Copy link

lyallh commented Mar 24, 2018

The problem is people who set menuBarVisiblity to hidden want to be able to toggle it open sometimes to use the menubar without having to go in to settings to make it visible. They could also pop it open with e.g. Alt+f to open the file menu but then it seems the menu is stuck open with no way to hide it but to fiddle around in settings again (another electron issue I guess..)

The toggleMenuBar action could solve this if it didn't change the user's setting to toggle instead of hidden. Discussed in #46181

@bpasero
Copy link
Member

bpasero commented Mar 24, 2018

@Krzysztof-Cieslak is this still an issue with our new builds that leverage Electron 2.0.0 (Windows, Linux)?

@vscodebot vscodebot bot closed this as completed Mar 31, 2018
@vscodebot
Copy link

vscodebot bot commented Mar 31, 2018

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.

Happy Coding!

@vscodebot vscodebot bot locked and limited conversation to collaborators May 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
info-needed Issue requires more information from poster
Projects
None yet
Development

No branches or pull requests

4 participants