No: "This setting must be a user setting" errors shown for code-workspace settings

[mjbvz]

Testing #33278

For the code-workspace:

{
	"folders": [
		{
			"path": "folder2"
		}
	],
	"settings": {
		"git.path": "hello"		
	}
}

git.path should be marked as only being supported in the user settings, similar to what we show if you try to set in on a folder:

Currently no error is shown:

[sandy081]

There is no classification of User/Workspace settings. We have Window and Resource settings. Window settings can be applied to complete workbench/window and can be configured in User / Workspace settings where are Resource settings can be applied only for resources and can be configured in User / Workspace / Folder settings.

Any setting can be customised from User / Workspace. This is the design decision and there are some advantages and disadvantages to it. From bright side, it will allow user to customise different gits for different workspaces.

[mjbvz]

Sorry, I think I posted the wrong screenshot of the expected error. Here's what I mean:

Settings for executables like git.path are only supported as user settings because they set the isExecutable flag in their settings contributions. In my testing, we don't show the green squiggles when you try to put one of these isExecutable settings into the code-workspace settings

[sandy081]

Ah I see.. right we have settings (exceptions) which are paths to executables and can only be user settings.

[ramya-rao-a]

Verified the fix for Workspace Settings in multi root mode.

But, in folder settings, in multi root mode, both messages are shown. The This setting cannot be applied now... doesn't apply

[sandy081]

It makes sense as both messages are applicable.