Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsaved changes error during settings migration #199736

Closed
sandy081 opened this issue Dec 1, 2023 · 2 comments · Fixed by #202703
Closed

Unsaved changes error during settings migration #199736

sandy081 opened this issue Dec 1, 2023 · 2 comments · Fixed by #202703
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug config VS Code configuration, set up issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded

Comments

@sandy081
Copy link
Member

sandy081 commented Dec 1, 2023

Steps to Reproduce:

  1. Have following settings in your workspace settings file
 "[typescript][javascript]": {
            "editor.insertSpaces": false,
            "editor.defaultFormatter": "vscode.typescript-language-features",
            "editor.formatOnSave": true,
            "editor.codeActionsOnSave": {
                "source.organizeImports": false,
                "source.fixAll": "never"
            }
          },
        "[python]": {
            "editor.codeActionsOnSave": {
                "source.organizeImports": true
            }
        },
        "editor.codeActionsOnSave": {
            "source.organizeImports": true
        },
  1. Reload window
  2. Settings are migrated properly but following error is shown

image

@sandy081 sandy081 added bug Issue identified by VS Code Team member as probable bug config VS Code configuration, set up issues labels Dec 1, 2023
@sandy081 sandy081 added this to the December 2023 milestone Dec 1, 2023
@sandy081 sandy081 self-assigned this Dec 1, 2023
@justschen
Copy link
Contributor

@sandy081 I wasn't able to repro this exactly on latest insiders. for me, it seemed to flash the warning really fast before disappearing

Screen.Recording.2023-12-01.at.10.02.42.AM.mov

@sandy081
Copy link
Member Author

sandy081 commented Dec 4, 2023

for me, it seemed to flash the warning really fast before disappearing

IMO this should not happen too. Anyway it is happening to me consistently and the error dialog remains.

sandy081 added a commit that referenced this issue Jan 18, 2024
sandy081 added a commit that referenced this issue Jan 18, 2024
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jan 18, 2024
@justschen justschen added the verified Verification succeeded label Jan 25, 2024
@aiday-mar aiday-mar added this to the December / January 2024 milestone Feb 6, 2024
@microsoft microsoft locked and limited conversation to collaborators Jun 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug config VS Code configuration, set up issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants