organizeImports update on workspace load adds additional settings

[karthiknadig]

Type: Bug

The auto update of organizeImports code action setting adds additional settings:

VS Code version: Code - Insiders 1.85.0-insider (b3a649f, 2023-11-15T09:43:13.091Z)
OS version: Windows_NT x64 10.0.19045
Modes:

System Info

Item	Value
CPUs	Intel(R) Core(TM) i7-1065G7 CPU @ 1.30GHz (8 x 1498)
GPU Status	2d_canvas: enabled canvas_oop_rasterization: enabled_on direct_rendering_display_compositor: disabled_off_ok gpu_compositing: enabled multiple_raster_threads: enabled_on opengl: enabled_on rasterization: enabled raw_draw: disabled_off_ok video_decode: enabled video_encode: enabled vulkan: disabled_off webgl: enabled webgl2: enabled webgpu: enabled
Load (avg)	undefined
Memory (System)	31.60GB (14.54GB free)
Process Argv	--folder-uri file:///c%3A/GIT/LSP/lsprotocol --log info --log ms-python.python:info --log github.vscode-pull-request-github:info --crash-reporter-id 4fb1ebc1-cf4c-4880-a88a-47738ec3768d
Screen Reader	no
VM	0%

Extensions (27)

Extension	Author (truncated)	Version
tsl-problem-matcher	amo	0.6.2
ruff	cha	2023.50.0
vscode-eslint	dba	2.4.2
gitlens	eam	14.5.0
EditorConfig	Edi	0.16.4
prettier-vscode	esb	10.1.0
copilot	Git	1.137.552
copilot-chat	Git	0.11.2023111501
remotehub	Git	0.62.0
vscode-github-actions	git	0.26.2
vscode-pull-request-github	Git	0.77.2023111514
vscode-docker	ms-	1.28.0
black-formatter	ms-	2023.7.13171007
python	ms-	2023.21.13181010
vscode-pylance	ms-	2023.11.12
remote-containers	ms-	0.321.0
remote-ssh	ms-	0.107.0
remote-ssh-edit	ms-	0.86.0
remote-wsl	ms-	0.81.8
vscode-remote-extensionpack	ms-	0.24.0
azure-account	ms-	0.11.6
remote-explorer	ms-	0.4.1
remote-repositories	ms-	0.40.0
remote-server	ms-	1.5.0
rust-analyzer	rus	0.4.1734
code-spell-checker	str	3.0.1
vscode-lldb	vad	1.10.0

A/B Experiments

vsliv695:30137379
vsins829:30139715
vsliv368cf:30146710
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
vstes627cf:30244335
vslsvsres303:30308271
pythontb:30258533
vsc_aacf:30263846
pythonptprofiler:30281269
vsdfh931:30280409
vshan820:30294714
vscod805cf:30301675
bridge0708:30335490
bridge0723:30353136
vsaa593cf:30376535
pythonvs932:30404738
py29gd2263:30784851
vsclangdf:30492506
c4g48928:30535728
dsvsc012cf:30540253
pynewext54:30618038
vscrpc:30624061
a9j8j154:30646983
showlangstatbar:30737417
pythonfmttext:30716741
fixshowwlkth:30771523
showindicator:30805243
pythongtdpath:30726887
i26e3531:30792625
welcomedialog:30812478
pythonnosmt12:30779711
pythonidxpt:30768918
pythonnoceb:30776497
synctok:30869157
dsvsc013:30777762
dsvsc014:30777825
pythonmpsinfo:30859869
dsvsc015:30821418
pythontestfixt:30866404
pythonregdiag2:30871582
pyreplss1:30879911
pythonmypyd1:30859725
pythoncet0:30859736
pythontbext0:30879054
accentitlementst:30870582
dsvsc016:30879898
dsvsc017:30880771
dsvsc018:30880772
aa_t_chat:30882232

[justschen]

cc @sandy081 not sure if this is an issue on my end with the migration from #198141 or something from this fix #194427 ?

[sandy081]

Are there steps to reproduce?

[karthiknadig]

@sandy081 All you need is this in your workspace settings:

{
    "editor.codeActionsOnSave": {
        "source.organizeImports": true
    },
    "[python]": {
        "editor.codeActionsOnSave": {
            "source.organizeImports.ruff": true
        }
    }
}

Add the above setting to your workspace before opening it in VS Code insiders.

[sandy081]

So is the following unexpected after migration?

"[python]": {
        "editor.codeActionsOnSave": {
            "source.organizeImports": "explicit",
        }
    }

[karthiknadig]

Correct. Expected is this:

{
    "editor.codeActionsOnSave": {
        "source.organizeImports": "explicit"
    },
    "[python]": {
        "editor.codeActionsOnSave": {
            "source.organizeImports.ruff": "explicit"
        }
    }
}

[sandy081]

I will investigate