Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid sync require for loading NLS configuration #159894

Closed
bpasero opened this issue Sep 2, 2022 · 1 comment
Closed

Avoid sync require for loading NLS configuration #159894

bpasero opened this issue Sep 2, 2022 · 1 comment
Assignees
@dbaeumer @TylerLeonhardt
Labels
insiders-released Patch has been released in VS Code Insiders perf perf-startup
Milestone
September 2022

Comments

@bpasero
Copy link
Member

bpasero commented Sep 2, 2022

Will provide a PR for this shortly.
@bpasero bpasero added this to the September 2022 milestone Sep 2, 2022
bpasero added a commit that referenced this issue Sep 2, 2022
@bpasero
Avoid sync require for loading NLS configuration (fix #159894)
b772d3c
@bpasero
Copy link
Member Author

bpasero commented Sep 2, 2022

#159895

@bpasero bpasero mentioned this issue Sep 2, 2022
Open
@bpasero bpasero closed this as completed in 92ecdac Sep 2, 2022
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Sep 2, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Oct 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@dbaeumer dbaeumer

@TylerLeonhardt TylerLeonhardt

Labels
insiders-released Patch has been released in VS Code Insiders perf perf-startup
Projects
None yet
Milestone
September 2022
Development

No branches or pull requests
4 participants
@bpasero @dbaeumer @TylerLeonhardt @vscodenpa