Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No path suggestions inside of angle bracet markdown link #152510

Closed
mjbvz opened this issue Jun 17, 2022 · 9 comments · Fixed by #153158
Closed

No path suggestions inside of angle bracet markdown link #152510

mjbvz opened this issue Jun 17, 2022 · 9 comments · Fixed by #153158
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug good first issue Issues identified as good for first-time contributors insiders-released Patch has been released in VS Code Insiders markdown Markdown support issues verified Verification succeeded
Milestone

Comments

@mjbvz
Copy link
Collaborator

mjbvz commented Jun 17, 2022

Issue Type: Bug

Trigger path suggestions inside a markdown link that uses angle brackets:

[text](<|>)

Bug
No suggestions show up

VS Code version: Code - Insiders 1.69.0-insider (Universal) (fbf1cf3, 2022-06-17T05:16:27.373Z)
OS version: Darwin x64 21.5.0
Restricted Mode: No

System Info
Item Value
CPUs Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz (16 x 2400)
GPU Status 2d_canvas: enabled
canvas_oop_rasterization: disabled_off
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
metal: disabled_off
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
skia_renderer: enabled_on
video_decode: enabled
video_encode: enabled
webgl: enabled
webgl2: enabled
Load (avg) 3, 4, 3
Memory (System) 32.00GB (0.01GB free)
Process Argv --crash-reporter-id 48781ca2-1705-4f64-9bab-325055aab55d
Screen Reader no
VM 0%
@mjbvz mjbvz self-assigned this Jun 17, 2022
@mjbvz mjbvz added bug Issue identified by VS Code Team member as probable bug good first issue Issues identified as good for first-time contributors labels Jun 17, 2022
@mjbvz mjbvz added this to the Backlog milestone Jun 17, 2022
@mjbvz mjbvz added the markdown Markdown support issues label Jun 17, 2022
@mjbvz
Copy link
Collaborator Author

mjbvz commented Jun 17, 2022

Relevant code:

private getPathCompletionContext(document: SkinnyTextDocument, position: vscode.Position): CompletionContext | undefined {

@DASchechtman
Copy link

So I'm new to this project. Do I ask if I can be assigned this bug? Or is it whoever submits an solution first makes the pull request?

@Harry-Hopkinson
Copy link

You can ask, I am currently working on this now - but you can try as well.

@DASchechtman
Copy link

Alright thanks. So in general I can just work on a problem that catches my attention and ask/answer questions when appropriate?

@Harry-Hopkinson
Copy link

Yes pretty much, you can work on any problem or issue that you would like.

@DASchechtman
Copy link

What specifically is the bug here? Is the desired behavior where when you type [text](<|>) a list of path links should appear?

@mjbvz
Copy link
Collaborator Author

mjbvz commented Jun 22, 2022

Yes, it should work the same way it does if you remove the <> from the link

One extra note: spaces should not be encoded inside <> links so for extra points make accepting a file suggestion with spaces in the name inserts a real space instead of %20

@DASchechtman
Copy link

DASchechtman commented Jun 22, 2022

How do I recompile typescript files so vscode reflects the changes I made? Is it yarn watch or Ctrl + Shift + B?

@DASchechtman
Copy link

Is this the behavior you were looking for?
link to screen recording

mjbvz added a commit to mjbvz/vscode that referenced this issue Jun 24, 2022
@vscodenpa vscodenpa added the unreleased Patch has not yet been released in VS Code Insiders label Jun 24, 2022
@mjbvz mjbvz modified the milestones: Backlog, June 2022 Jun 24, 2022
@vscodenpa vscodenpa added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jun 27, 2022
@joyceerhl joyceerhl added the verified Verification succeeded label Jun 30, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Aug 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug good first issue Issues identified as good for first-time contributors insiders-released Patch has been released in VS Code Insiders markdown Markdown support issues verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants