Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No prompt when accepting merges with conflicts #151024

Closed
karrtikr opened this issue Jun 1, 2022 · 2 comments · Fixed by #153211
Closed

No prompt when accepting merges with conflicts #151024

karrtikr opened this issue Jun 1, 2022 · 2 comments · Fixed by #153211
Assignees
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders merge-editor verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@karrtikr
Copy link
Contributor

karrtikr commented Jun 1, 2022

Testing #150389

Expected to see:

image

but changes were staged with conflicts.

@hediet hediet added this to the June 2022 milestone Jun 2, 2022
@hediet hediet added feature-request Request for new features or functionality merge-editor labels Jun 2, 2022
jrieken added a commit that referenced this issue Jun 25, 2022
…to close a merge editor despite unresolved conflicts. As a side-effect keep the merge editor dirty while it is unsed and while it has unresolved conflicts

fixes #151024
@jrieken
Copy link
Member

jrieken commented Jun 25, 2022

Screenshot 2022-06-25 at 18 22 22

⬆️ that's how it will look, with PR #153211. open for working tweaks

jrieken added a commit that referenced this issue Jun 26, 2022
implement `IEditorInput#confirm` to confirm with users that it is OK to close a merge editor despite unresolved conflicts. As a side-effect keep the merge editor dirty while it is unsed and while it has unresolved conflicts

fixes #151024
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jun 26, 2022
@jrieken jrieken added the verification-needed Verification of issue is requested label Jun 27, 2022
@jrieken
Copy link
Member

jrieken commented Jun 27, 2022

To verify:

  • enable auto-save (File > ✔️ Auto Save )
  • open merge editor (see below)
  • close the editor while having unhandled conflicts
  • ensure a modal confirm message shows
  • make sure the working makes sense
  • make sure the message doesn't show when pressing 'Accept'
  • disable auto-save (File > Auto Save )
  • repeat the steps and verify that you can close without save

To get a merge conflict and editor

  • use this setting "git.mergeEditor": true
  • run the commands below
  • open the conflict from the SCM view
git clone https://github.com/hediet/vscode-3wm-test-repo.git
cd vscode-3wm-test-repo
git fetch --all
git checkout input1
git merge input2

@connor4312 connor4312 added the verified Verification succeeded label Jun 28, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Aug 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders merge-editor verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants