Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minimum contrast ratio isn't working for inverted text in DOM renderer #150992

Closed
Tyriar opened this issue Jun 1, 2022 · 0 comments · Fixed by #151169
Closed

Minimum contrast ratio isn't working for inverted text in DOM renderer #150992

Tyriar opened this issue Jun 1, 2022 · 0 comments · Fixed by #151169
Assignees
@Tyriar @meganrogge
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal-rendering upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-fixed The underlying upstream issue has been fixed upstream-issue-linked This is an upstream issue that has been reported upstream verified Verification succeeded
Milestone
May 2022

Comments

@Tyriar
Copy link
Member

Tyriar commented Jun 1, 2022

Repro:

Set:

  "terminal.integrated.gpuAcceleration": "off",
  "terminal.integrated.minimumContrastRatio": 4.5,

image

When set to 9:

image

Upstream: xtermjs/xterm.js#3846
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug upstream Issue identified as 'upstream' component related (exists outside of VS Code) accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues upstream-issue-linked This is an upstream issue that has been reported upstream terminal-rendering labels Jun 1, 2022
@Tyriar Tyriar added this to the May 2022 milestone Jun 1, 2022
@Tyriar Tyriar added the upstream-issue-fixed The underlying upstream issue has been fixed label Jun 2, 2022
Tyriar added a commit that referenced this issue Jun 2, 2022
@Tyriar
Update xterm

Unverified

This user has not yet uploaded their public signing key.
GPG key ID: 37FF5F19022427F2
Learn about vigilant mode
ea9d498 
Fixes #150777
Fixes #150992
@Tyriar Tyriar mentioned this issue Jun 2, 2022
Merged
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jun 2, 2022
@Tyriar Tyriar added the verified Verification succeeded label Jun 3, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jul 17, 2022
lemanschik pushed a commit to code-oss-dev/code that referenced this issue Nov 25, 2022
@Tyriar
Update xterm
bbdaca4 
Fixes microsoft#150777
Fixes microsoft#150992
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

@meganrogge meganrogge

Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal-rendering upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-fixed The underlying upstream issue has been fixed upstream-issue-linked This is an upstream issue that has been reported upstream verified Verification succeeded
Projects
None yet
Milestone
May 2022
Development

Successfully merging a pull request may close this issue.

Update xterm microsoft/vscode
3 participants
@Tyriar @meganrogge @vscodenpa