Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mix of custom and native hover in title #150788

Closed
bpasero opened this issue May 31, 2022 · 0 comments · Fixed by #153166
Closed

Mix of custom and native hover in title #150788

bpasero opened this issue May 31, 2022 · 0 comments · Fixed by #153166
Assignees
@sbatten
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders titlebar VS Code main title bar issues ux User experience issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone
June 2022

Comments

@bpasero
Copy link
Member

bpasero commented May 31, 2022

With the introduction of command center that uses custom hover, we now have custom and native hovers. I wonder if we should just pick custom hovers to be consistent.

Recording 2022-05-31 at 10 46 22

//cc @daviddossett @misolori
@bpasero bpasero added the titlebar VS Code main title bar issues label May 31, 2022
@bpasero bpasero added the ux User experience issues label May 31, 2022
@sbatten sbatten added this to the June 2022 milestone May 31, 2022
@sbatten sbatten added the feature-request Request for new features or functionality label May 31, 2022
sbatten added a commit that referenced this issue Jun 24, 2022
@sbatten
Improve hovers in title bar
4c6247f 
fixes #150788

- add a new delegate for the titlebar to handle the hover for the layout
	controls
- reuse the hover delegate in the command center
- don't show hover for application menu/overflow menu
@sbatten sbatten mentioned this issue Jun 24, 2022
Merged
sbatten added a commit that referenced this issue Jun 24, 2022
@sbatten
Improve hovers in title bar (#153166)
fff8f8a 
fixes #150788

- add a new delegate for the titlebar to handle the hover for the layout
	controls
- reuse the hover delegate in the command center
- don't show hover for application menu/overflow menu
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jun 24, 2022
@sbatten sbatten added the verification-needed Verification of issue is requested label Jun 27, 2022
@jrieken jrieken added the verified Verification succeeded label Jun 28, 2022
@jrieken jrieken mentioned this issue Jun 28, 2022
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sbatten sbatten

Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders titlebar VS Code main title bar issues ux User experience issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
June 2022
Development

Successfully merging a pull request may close this issue.

Improve hovers in title bar microsoft/vscode
4 participants
@bpasero @jrieken @sbatten @vscodenpa