Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display language identifier in Language Mode drop down #11977

Closed
gregvanl opened this issue Sep 13, 2016 · 9 comments
Closed

Display language identifier in Language Mode drop down #11977

gregvanl opened this issue Sep 13, 2016 · 9 comments
Assignees
Labels
feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded

Comments

@gregvanl
Copy link

gregvanl commented Sep 13, 2016

Many user settings need to know a language's language id. Examples include files.associations, emmet.syntaxProfiles, emmet.excludeLanguages. Some settings display the language id list in suggestions (ex. files.associations) but not others (ex. emmet.syntaxProfiles).
vscode-docs issue microsoft/vscode-docs#572 recommends documenting the most commonly used language ids but this list will be long and need to be maintained.
We could display the language id in the Language Mode drop down list. Perhaps in parentheses:
JavaScript (javascript)
C++ (cpp)
The "languages" message on the upper right of the dropdown could be changed to something like "languages (language identifier)" or expand to a full description of language ids.
This way the list will be scoped to only languages the user has installed and always up to date. The list will also be discoverable in the product and not require the user to search our doc website

@bpasero bpasero added feature-request Request for new features or functionality help wanted Issues identified as good community contribution opportunities labels Sep 14, 2016
@bpasero bpasero added this to the Backlog milestone Sep 14, 2016
@bpasero
Copy link
Member

bpasero commented Sep 14, 2016

Sounds like an easy enough area for a PR 👍

@bpasero bpasero added the good first issue Issues identified as good for first-time contributors label Sep 14, 2016
@mrmlnc
Copy link
Contributor

mrmlnc commented Sep 14, 2016

Perhaps in parentheses:
JavaScript (javascript)
C++ (cpp)

In this case, Configured Language will be visually lost 🐱.

image

Maybe add a dash?

image

Or drop parentheses for language identifier:

image

@bpasero
Copy link
Member

bpasero commented Sep 14, 2016

@mrmlnc happy to review a PR if you wanna give it a shot 👍

@bpasero bpasero modified the milestones: September 2016, Backlog Sep 14, 2016
@bpasero bpasero self-assigned this Sep 14, 2016
@bpasero bpasero removed good first issue Issues identified as good for first-time contributors help wanted Issues identified as good community contribution opportunities labels Sep 14, 2016
@bpasero bpasero closed this as completed Sep 14, 2016
@bpasero
Copy link
Member

bpasero commented Sep 14, 2016

@gregvanl @egamma here is how it looks like after @mrmlnc PR, let me know if we should tweak it further:

screen shot 2016-09-14 at 17 46 32

@gregvanl
Copy link
Author

@bpasero I think I like the parentheses and dash for Configured Language better. I would also add some explanation in the upper right where now it just says "languages". Maybe "languages and language identifiers" or "languages (language identifier)" if we use parentheses.

@egamma
Copy link
Member

egamma commented Sep 15, 2016

Another rendering would be to right align the language IDs on the right, same as we do it with the key bindings

@bpasero
Copy link
Member

bpasero commented Sep 16, 2016

Not such a big fan of that:

screen shot 2016-09-16 at 05 46 18

@gregvanl
Copy link
Author

Reopening as I think we need to explain that language identifiers are in parentheses. Maybe changing the upper right text from "languages" to "languages (language identifier)"

@gregvanl gregvanl reopened this Sep 21, 2016
bpasero added a commit that referenced this issue Sep 22, 2016
@bpasero
Copy link
Member

bpasero commented Sep 22, 2016

Makes sense.

@bpasero bpasero closed this as completed Sep 22, 2016
@gregvanl gregvanl added the verified Verification succeeded label Sep 22, 2016
@bpasero bpasero added the verification-needed Verification of issue is requested label Sep 23, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants