Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

circular symlink breaks typescript intellisense #11773

Closed
bedorlan opened this issue Sep 9, 2016 · 4 comments
Closed

circular symlink breaks typescript intellisense #11773

bedorlan opened this issue Sep 9, 2016 · 4 comments
Assignees
Labels
typescript Typescript support issues

Comments

@bedorlan
Copy link

bedorlan commented Sep 9, 2016

Steps to Reproduce:

  1. Before creating symlink, intellisense works:
    good
  2. Inside some project folder, create symbolic link to parent folder
    $ ln -s ../../ baselibs
  3. Restart vscode
  4. Now intellisense fails:
    bad

My project folder has 16942 files and 2944 folders. I try to reproduce the issue in a simpler folder structure, but i couldn't.

I also tried to ignore the symlink in the settings.json, but this doesn't fix the issue.

Gladly i'll provide more info.

  • VSCode Version:
    Versión 1.5.1
    Confirmación 07d663d
    Fecha 2016-09-08T21:34:58.760Z
    Shell 0.37.6
    Representador 49.0.2623.75
    Node 5.10.0
  • OS Version:
    Linux os006724 4.6.0-1-amd64 Open Source VS Code #1 SMP Debian 4.6.4-1 (2016-07-18) x86_64 GNU/Linux
@ramya-rao-a ramya-rao-a added the typescript Typescript support issues label Sep 9, 2016
@waderyan
Copy link

waderyan commented Sep 9, 2016

@bedorlan thank you for reporting this issue. Is it possible for you to share your project so we can try and reproduce on our end?

@dbaeumer this is a tough one. He wasn't able to reproduce with a simpler structure. Any thoughts?

@waderyan waderyan added the info-needed Issue requires more information from poster label Sep 9, 2016
@bedorlan
Copy link
Author

bedorlan commented Sep 9, 2016

Finally, i was able to reproduce the issue. project attached.

project.zip

Steps to Reproduce:

  1. uncompress project.zip & project.tgz (automatic symlinks)
  2. open the folder project
  3. open the file 0/1/2/test.ts
  4. try intellisense

tip: i'm using a custom typescript sdk:

{
    "typescript.tsdk": "./node_modules/typescript/lib"
}

@dbaeumer
Copy link
Member

@waderyan pretty sure this is a tsserver issue. Since they load the whole project I don't know whether they 'normalize' links to avoid traversing the cycle endlessly.

@waderyan waderyan removed info-needed Issue requires more information from poster typescript Typescript support issues labels Sep 12, 2016
@waderyan
Copy link

This issue was moved to microsoft/TypeScript#10873

@waderyan waderyan added the typescript Typescript support issues label Sep 12, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
typescript Typescript support issues
Projects
None yet
Development

No branches or pull requests

4 participants