Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

circular symlink breaks typescript intellisense #10873

Open
waderyan opened this issue Sep 12, 2016 · 3 comments
Open

circular symlink breaks typescript intellisense #10873

waderyan opened this issue Sep 12, 2016 · 3 comments
Labels
Bug A bug in TypeScript VS Code Tracked There is a VS Code equivalent to this issue
Milestone

Comments

@waderyan
Copy link

From @bedorlan on September 9, 2016 13:47

Steps to Reproduce:

  1. Before creating symlink, intellisense works:
    good
  2. Inside some project folder, create symbolic link to parent folder
    $ ln -s ../../ baselibs
  3. Restart vscode
  4. Now intellisense fails:
    bad

My project folder has 16942 files and 2944 folders. I try to reproduce the issue in a simpler folder structure, but i couldn't.

I also tried to ignore the symlink in the settings.json, but this doesn't fix the issue.

Gladly i'll provide more info.

  • VSCode Version:
    Versión 1.5.1
    Confirmación 07d663dc1bd848161edf4cd4ce30cce410d3d877
    Fecha 2016-09-08T21:34:58.760Z
    Shell 0.37.6
    Representador 49.0.2623.75
    Node 5.10.0
  • OS Version:
    Linux os006724 4.6.0-1-amd64 Suggestion: 'protected' modifier #1 SMP Debian 4.6.4-1 (2016-07-18) x86_64 GNU/Linux

Copied from original issue: microsoft/vscode#11773

@waderyan
Copy link
Author

@bedorlan thank you for reporting this issue. Is it possible for you to share your project so we can try and reproduce on our end?

@dbaeumer this is a tough one. He wasn't able to reproduce with a simpler structure. Any thoughts?

@waderyan waderyan self-assigned this Sep 12, 2016
@waderyan
Copy link
Author

From @bedorlan on September 9, 2016 21:38

Finally, i was able to reproduce the issue. project attached.

project.zip

Steps to Reproduce:

  1. uncompress project.zip & project.tgz (automatic symlinks)
  2. open the folder project
  3. open the file 0/1/2/test.ts
  4. try intellisense

tip: i'm using a custom typescript sdk:

{
    "typescript.tsdk": "./node_modules/typescript/lib"
}

@waderyan
Copy link
Author

From @dbaeumer on September 11, 2016 19:37

@waderyan pretty sure this is a tsserver issue. Since they load the whole project I don't know whether they 'normalize' links to avoid traversing the cycle endlessly.

@waderyan waderyan removed their assignment Sep 12, 2016
@mhegazy mhegazy added the Bug A bug in TypeScript label Dec 15, 2016
@mhegazy mhegazy added this to the Future milestone Dec 15, 2016
@mhegazy mhegazy added the VS Code Tracked There is a VS Code equivalent to this issue label Dec 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A bug in TypeScript VS Code Tracked There is a VS Code equivalent to this issue
Projects
None yet
Development

No branches or pull requests

3 participants