Skip to content

Commit

Permalink
#53526 Migrate away from TPromise in Problems panel
Browse files Browse the repository at this point in the history
  • Loading branch information
sandy081 committed Nov 9, 2018
1 parent 0e966cd commit f6ab430
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
import 'vs/css!./media/markers';

import { URI } from 'vs/base/common/uri';
import { TPromise } from 'vs/base/common/winjs.base';
import * as dom from 'vs/base/browser/dom';
import { IAction, IActionItem, Action } from 'vs/base/common/actions';
import { ITelemetryService } from 'vs/platform/telemetry/common/telemetry';
Expand Down Expand Up @@ -202,7 +201,7 @@ export class MarkersPanel extends Panel implements IMarkerFilterController {
return false;
}

private refreshPanel(): TPromise<any> {
private refreshPanel(): void {
if (this.isVisible()) {
this.cachedFilterStats = undefined;
this.tree.setChildren(null, createModelIterator(this.markersWorkbenchService.markersModel));
Expand All @@ -212,7 +211,6 @@ export class MarkersPanel extends Panel implements IMarkerFilterController {
this.renderMessage();
this._onDidFilter.fire();
}
return TPromise.as(null);
}

private updateFilter() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@

import { Delayer } from 'vs/base/common/async';
import * as DOM from 'vs/base/browser/dom';
import { TPromise } from 'vs/base/common/winjs.base';
import { Action, IAction, IActionChangeEvent } from 'vs/base/common/actions';
import { HistoryInputBox } from 'vs/base/browser/ui/inputbox/inputBox';
import { KeyCode } from 'vs/base/common/keyCodes';
Expand Down Expand Up @@ -69,7 +68,7 @@ export class ShowProblemsPanelAction extends Action {
super(id, label);
}

public run(): TPromise<any> {
public run(): Thenable<any> {
this.panelService.openPanel(Constants.MARKERS_PANEL_ID, true);
return Promise.resolve(null);
}
Expand Down Expand Up @@ -347,7 +346,7 @@ export class QuickFixAction extends Action {
}));
}

public openFileAtMarker(element: Marker): TPromise<void> {
public openFileAtMarker(element: Marker): Thenable<void> {
const { resource, selection } = { resource: element.resource, selection: element.range };
return this.editorService.openEditor({
resource,
Expand Down

0 comments on commit f6ab430

Please sign in to comment.