web - align API with what we expect

microsoft · Aug 28, 2019 · f682e3b · f682e3b
1 parent 902da82
commit f682e3b
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/src/vs/workbench/services/remote/browser/remoteAgentServiceImpl.ts b/src/vs/workbench/services/remote/browser/remoteAgentServiceImpl.ts
@@ -30,7 +30,10 @@ export class RemoteAgentService extends AbstractRemoteAgentService implements IR
 		super(environmentService);
 
 		this.socketFactory = new BrowserSocketFactory(webSocketFactory);
-		this._connection = this._register(new RemoteAgentConnection(environmentService.configuration.remoteAuthority!, productService.commit, this.socketFactory, remoteAuthorityResolverService, signService, logService));
+		const remoteAuthority = environmentService.configuration.remoteAuthority;
+		if (remoteAuthority) {
+			this._connection = this._register(new RemoteAgentConnection(remoteAuthority, productService.commit, this.socketFactory, remoteAuthorityResolverService, signService, logService));
+		}
 	}
 
 	getConnection(): IRemoteAgentConnection | null {

diff --git a/src/vs/workbench/workbench.web.api.ts b/src/vs/workbench/workbench.web.api.ts
@@ -19,7 +19,7 @@ export interface IWorkbenchConstructionOptions {
 	 * Experimental: the remote authority is the IP:PORT from where the workbench is served
 	 * from. It is for example being used for the websocket connections as address.
 	 */
-	remoteAuthority: string;
+	remoteAuthority?: string;
 
 	/**
 	 * The connection token to send to the server.