Merge pull request #209037 from microsoft/tyriar/208640

createDataStream -> readData
microsoft · Mar 29, 2024 · 960217f · 960217f
2 parents 7955ac4 + ae5e0c1
commit 960217f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/vs/workbench/api/common/extHostTerminalShellIntegration.ts b/src/vs/workbench/api/common/extHostTerminalShellIntegration.ts
@@ -238,7 +238,7 @@ class InternalTerminalShellExecution {
 			get cwd(): URI | undefined {
 				return that.cwd;
 			},
-			createDataStream(): AsyncIterable<string> {
+			readData(): AsyncIterable<string> {
 				return that._createDataStream();
 			}
 		};

diff --git a/src/vscode-dts/vscode.proposed.terminalShellIntegration.d.ts b/src/vscode-dts/vscode.proposed.terminalShellIntegration.d.ts
@@ -44,12 +44,12 @@ declare module 'vscode' {
 		 * @example
 		 * // Log all data written to the terminal for a command
 		 * const command = term.shellIntegration.executeCommand({ commandLine: 'echo "Hello world"' });
-		 * const stream = command.createDataStream();
+		 * const stream = command.readData();
 		 * for await (const data of stream) {
 		 *   console.log(data);
 		 * }
 		 */
-		createDataStream(): AsyncIterable<string>;
+		readData(): AsyncIterable<string>;
 	}
 
 	export interface Terminal {