working proposal for autofix based on eslint example

[rlasjunies]

Hi @egamma,

As proposed here is the PR for tslint autofix.

• it's based on eslint autofix proposal
• autofix rules are stored in a dedicated file: tslintautofix.ts (7 autofix for now, willing to increase)

Work pretty fine for now.

Let me know your feeling.

BR

[egamma]

@rlasjunies thanks, I took a quick look at the code and it looks promising. I need more time for a deeper look.

I think we would get more quick fixes if the tslintautofix.ts becomes part of tslint, the way you wrote the code it is independent of VS Code. @unional, @jkillian what do you think?

[jkillian]

Hi all, auto-fixing problems is a feature that we'd like to have in TSLint, although as far as I know, there's been no implementation work on it (outside of this anyways). It would probably be best to have a short proposal written up there documenting what sort of API a feature like this would have and basic implementation ideas over in palantir/tslint#561

[egamma]

@jkillian makes sense to start with an API proposal.
Since VS Code integrates several linters it would be desirable when the different linters use a similar API for auto fixing. I therefore suggest to also consider the ESlint as a source for inspiration.

@rlasjunies do you have the cycles for this? we could also involve @dbaeumer given his autofix work for eslint.

I'll still look into make this PR available in the tslint extension so that we get feedback from users on the auto fix UI support.

[rlasjunies]

Hi @egamma, @jkillian,

I'll will have a look in the TSLint API, digest and hopefully propose something ;-)

This week will be hard ... beginning of May I'll be back to you.

[egamma]

@rlasjunies I'll reopen since I still want to look into it and will try to make it available as is so that we get feedback from users. This is independent of whether the autofixes come from tslint or here.

[egamma]

The PR looks good, thanks @rlasjunies !

[ericanderson]

This was announced in today's update for VSC, but doesn't seem to be shipped?

[egamma]

Thanks for the reminder. Published the version as 0.5.25.