Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add experimental runner cli #235

Closed
wants to merge 3 commits into from
Closed

Conversation

connor4312
Copy link
Member

The context behind this is wanting a standard way to run VS Code tests, with which we can build an extension that shows VS Code tests in the test explorer. This does that. The previous APIs are there and will always be supported as an alternative way to run tests.

See the readme for usage. Integration in js-debug for "debugging" is not there yet, but it will come.

The context behind this is wanting a standard way to run VS Code tests,
with which we can build an extension that shows VS Code tests in the
test explorer. This does that. The previous APIs are there and will
always be supported as an alternative way to run tests.

See the readme for usage. Integration in js-debug for "debugging" is
not there yet, but it will come.
@felipecrs
Copy link

Some feedback I have:

  1. Isn't test-electron a too generic CLI name? How about vscode-test? Maybe someday Electron folks creates a test-electron CLI and this could cause some confusion.
  2. I would suggest allowing to configure the test also through a vscode-test key under the package.json. Pretty much everything else for VS Code extensions can be configured there, like vsce.

@connor4312
Copy link
Member Author

  1. Naming was a typo in the readme, will fix
  2. That's reasonable

@aeschli
Copy link

aeschli commented Sep 25, 2023

Could this be done in a separate node module that uses @vscode/test-electron as a utility? That way @vscode/test-electron
stays test runner agnostic and has the sole job of downloading a VS Code instance.

@connor4312
Copy link
Member Author

That could work, particularly if that "agnostic" CLI works with test-web later as well.

@connor4312 connor4312 disabled auto-merge September 25, 2023 21:56
@felipecrs
Copy link

And then electron-test and web-test would be both optional peer dependencies of it?

https://stackoverflow.com/a/66228639

@connor4312
Copy link
Member Author

Yep

Copy link

@remcohaszing remcohaszing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love the direction this is going in!

README.md Show resolved Hide resolved
lib/cli-runner/runner.ts Show resolved Hide resolved
lib/cli-runner/bin.ts Show resolved Hide resolved
README.md Show resolved Hide resolved
@connor4312 connor4312 added this to the October 2023 milestone Sep 26, 2023
@connor4312
Copy link
Member Author

Going to close and reopen this in a new repo as Martin suggested.

@connor4312 connor4312 closed this Oct 9, 2023
connor4312 added a commit to microsoft/vscode-test-cli that referenced this pull request Oct 11, 2023
This creates a `@vscode/test-cli` NPM module that exposes a `vscode-test`
command line.

This reads a configuration file, described in the readme, and runs all
tests defined therein by default. Multiple configurations can be defined,
in which case they are all run sequentially.

See previous discussion on microsoft/vscode-test#235
This is largely the same as the version in that PR, with the addition
of a reporter and addressed comments.
@connor4312
Copy link
Member Author

Now in microsoft/vscode-test-cli#1

I also have the extension to integrate in VS Code ready to go, which I'll share after the CLI gets published 🙂

connor4312 added a commit to microsoft/vscode-test-cli that referenced this pull request Oct 11, 2023
This creates a `@vscode/test-cli` NPM module that exposes a `vscode-test`
command line.

This reads a configuration file, described in the readme, and runs all
tests defined therein by default. Multiple configurations can be defined,
in which case they are all run sequentially.

See previous discussion on microsoft/vscode-test#235
This is largely the same as the version in that PR, with the addition
of a reporter and addressed comments.
@connor4312
Copy link
Member Author

Extension to run tests in VS Code 👉 https://github.com/microsoft/vscode-extension-test-runner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants