Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix feedback service #246

Merged
merged 8 commits into from
Nov 21, 2017
Merged

Conversation

DonJayamanne
Copy link

Fixes #245

@brettcannon
Copy link
Member

@DonJayamanne Travis isn't happy.

@DonJayamanne
Copy link
Author

@brettcannon , after three attempts, it worked

@DonJayamanne DonJayamanne added this to the December 2017 milestone Nov 17, 2017
@DonJayamanne DonJayamanne merged commit ca9b428 into microsoft:master Nov 21, 2017
@refeed
Copy link

refeed commented Dec 10, 2017

btw, when will vscode with this patch released ?

@DonJayamanne
Copy link
Author

Next week, we have a release planned for mid December

@refeed
Copy link

refeed commented Dec 10, 2017

Oh okay, I'll wait for that release :)

@DonJayamanne DonJayamanne deleted the FixFeedbackService branch December 12, 2017 21:22
DonJayamanne added a commit that referenced this pull request Dec 14, 2017
* upstream/master:
  Fix feedback service (#246)
  Fix django context initializer (#248)
  disable generation of tags file upon extension load (#264)
@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feed back service throws an exception after submitting a feedback
4 participants