-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle line formatting when line is in a middle or at the end of a multiline string #2424
Conversation
Added setting to control language server log output through the `python.analysis.logLevel` setting (the default is now 'Error'). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why it shows it as new...
Codecov Report
@@ Coverage Diff @@
## master #2424 +/- ##
==========================================
+ Coverage 75.4% 75.53% +0.12%
==========================================
Files 309 309
Lines 14331 14390 +59
Branches 2536 2542 +6
==========================================
+ Hits 10807 10870 +63
+ Misses 3515 3512 -3
+ Partials 9 8 -1
Continue to review full report at Codecov.
|
}); | ||
test('Grammar file', function () { | ||
// tslint:disable-next-line:no-invalid-this | ||
this.timeout(50000); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps reconsider adding 50 seconds to our test run time. Maybe the async file read version would help? Then do the testing part via the .then
clause.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is just an experiment, the test takes ~6s on desktop. It was timing out, I wanted to check if it is Travis VM that is slow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Understood! (I'm struggling with a test timeout issue now too - so frustrating!).
Closing in favor of microsoft/python-language-server#5 |
Fixes #2323