Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for breaking into the first line of code in the new debugger #2311

Merged
merged 1 commit into from
Aug 1, 2018

Conversation

DonJayamanne
Copy link

Fixes #2299

  • Title summarizes what is changing
  • Includes a news entry file (remember to thank yourself!)
  • [n/a] Unit tests & code coverage are not adversely affected (within reason)
  • Works on all actively maintained versions of Python (e.g. Python 2.7 & the latest Python 3 release)
  • Works on Windows 10, macOS, and Linux (e.g. considered file system case-sensitivity)
  • [n/a] Dependencies are pinned (e.g. "1.2.3", not "^1.2.3")
  • [n/a] package-lock.json has been regenerated if dependencies have changed

@ericsnowcurrently ericsnowcurrently self-requested a review August 1, 2018 21:10
Copy link
Member

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Aug 1, 2018

Codecov Report

Merging #2311 into master will decrease coverage by <.01%.
The diff coverage is 80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2311      +/-   ##
==========================================
- Coverage   75.59%   75.59%   -0.01%     
==========================================
  Files         309      309              
  Lines       14336    14339       +3     
  Branches     2539     2540       +1     
==========================================
+ Hits        10838    10840       +2     
- Misses       3488     3489       +1     
  Partials       10       10
Flag Coverage Δ
#MacOS 73.88% <80%> (-0.01%) ⬇️
#Windows 74.02% <80%> (ø) ⬆️
Impacted Files Coverage Δ
src/client/debugger/Common/Contracts.ts 100% <100%> (ø) ⬆️
...c/client/debugger/DebugClients/LocalDebugClient.ts 56.3% <100%> (ø) ⬆️
...lient/debugger/configProviders/pythonV2Provider.ts 86.58% <50%> (-0.92%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f01c810...d8eaa8d. Read the comment docs.

@DonJayamanne DonJayamanne merged commit a7908ab into microsoft:master Aug 1, 2018
@DonJayamanne DonJayamanne deleted the issue2299 branch October 2, 2018 22:46
@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for stop on entry in experimental debugger
2 participants