Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove envShellEvent proposal usage #21997

Merged
merged 1 commit into from
Sep 15, 2023
Merged

Remove envShellEvent proposal usage #21997

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
"enabledApiProposals": [
"contribEditorContentMenu",
"quickPickSortByLabel",
"envShellEvent",
"testObserver",
"quickPickItemTooltip",
"saveEditor"
Expand All @@ -44,7 +43,7 @@
"theme": "dark"
},
"engines": {
"vscode": "^1.82.0-20230830"
"vscode": "^1.83.0-20230915"
Copy link

@karrtikr karrtikr Sep 16, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Tyriar This prevents us from releasing pre-releases for stable VS Code #22005 (comment), is this necessary to remove envShellEvent?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this the same thing we did when removing the other proposal? Removing the proposal from the package.json only means stable pre-releases would not be allowed to use envShellEvent.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant, does VS Code engine needed to be updated to Insiders?

We would prefer it to be latest VS Code stable engine, so that we can publish pre releases in VS Code stable as well.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm just going off what you said in #21900 (review)

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, that was because distro was just updated before that PR: microsoft/vscode#191815.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same thing happened in distro

},
"enableTelemetry": false,
"keywords": [
Expand Down Expand Up @@ -2221,4 +2220,4 @@
"webpack-require-from": "^1.8.6",
"yargs": "^15.3.1"
}
}
}