Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move service registrations from debug adapter host to extension host #2193

Merged
merged 2 commits into from
Jul 18, 2018
Merged

Move service registrations from debug adapter host to extension host #2193

merged 2 commits into from
Jul 18, 2018

Conversation

DonJayamanne
Copy link

Fixes #2191

  • Title summarizes what is changing
  • [n/a] Includes a news entry file (remember to thank yourself!)
  • [n/a] Unit tests & code coverage are not adversely affected (within reason)
  • Works on all actively maintained versions of Python (e.g. Python 2.7 & the latest Python 3 release)
  • Works on Windows 10, macOS, and Linux (e.g. considered file system case-sensitivity)
  • [n/a] Dependencies are pinned (e.g. "1.2.3", not "^1.2.3")
  • [n/a] package-lock.json has been regenerated if dependencies have changed

d3r3kk
d3r3kk approved these changes Jul 18, 2018
View reviewed changes
Copy link

@d3r3kk d3r3kk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Don!

@DonJayamanne DonJayamanne merged commit 6af8f99 into microsoft:master Jul 18, 2018
bschley pushed a commit to bschley/vscode-python that referenced this pull request Aug 2, 2018
@DonJayamanne @bschley
Move service registrations from debug adapter host to extension host (m…
1105199 
…icrosoft#2193)

Fixes microsoft#2191
@DonJayamanne DonJayamanne deleted the issue2191ServiceRegs branch October 2, 2018 22:47
@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@brettcannon brettcannon brettcannon approved these changes

@d3r3kk d3r3kk d3r3kk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move service registrations from debug adapter host into extension host
3 participants
@DonJayamanne @brettcannon @d3r3kk