Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct tsconfig.json when generating npm package #21651

Merged
merged 5 commits into from
Jul 17, 2023
Merged

Use correct tsconfig.json when generating npm package #21651

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1d8bcf6
Use correct `tsconfig.json` when generating npm package
Jul 17, 2023
48394fb
Add comment
Jul 17, 2023
afc973f
Update version
Jul 17, 2023
4509cac
Nicely format declaration files
Jul 17, 2023
6179069
Fix main.ts
Jul 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions pythonExtensionApi/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 4 additions & 1 deletion pythonExtensionApi/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,13 @@
"dependencies": {
"@types/vscode": "^1.78.0"
},
"devDependencies": {
"typescript": "5.0.4"
},
"scripts": {
"prepublishOnly": "echo \"⛔ Can only publish from a secure pipeline ⛔\" && node ../build/fail",
"prepack": "npm run all:publish",
"compile": "node ../node_modules/typescript/lib/tsc.js -b ./tsconfig.json",
"compile": "node ./node_modules/typescript/lib/tsc.js -b ./tsconfig.json",
"clean": "node ../node_modules/rimraf/bin.js out",
"lint": "node ../node_modules/eslint/bin/eslint.js --ext ts src",
"all": "npm run clean && npm run compile",
Expand Down
3 changes: 3 additions & 0 deletions pythonExtensionApi/src/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -392,6 +392,9 @@ export const PVSC_EXTENSION_ID = 'ms-python.python';

// eslint-disable-next-line @typescript-eslint/no-namespace
export namespace PythonExtension {
/**
* Returns the API exposed by the Python extension in VS Code.
*/
export async function api(): Promise<PythonExtension> {
const extension = extensions.getExtension(PVSC_EXTENSION_ID);
if (extension === undefined) {
Expand Down
2 changes: 1 addition & 1 deletion pythonExtensionApi/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
"noUnusedParameters": true,
"noFallthroughCasesInSwitch": true,
"resolveJsonModule": true,
"removeComments": true
"declaration": true
},
"exclude": [
"node_modules",
Expand Down