Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CONTRIBUTING - LANGUAGE SERVER.md #2161

Merged
merged 1 commit into from
Jul 18, 2018
Merged

Update CONTRIBUTING - LANGUAGE SERVER.md #2161

merged 1 commit into from
Jul 18, 2018

Conversation

d3r3kk
Copy link

@d3r3kk d3r3kk commented Jul 16, 2018

Fix incomplete path given in instructions to build PTVS with.

  • Title summarizes what is changing

@d3r3kk d3r3kk requested review from brettcannon and DonJayamanne and removed request for brettcannon July 16, 2018 17:23
Copy link

@DonJayamanne DonJayamanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please create news entry for this.

@DonJayamanne
Copy link

@d3r3kk Please use the PR template.

@brettcannon
Copy link
Member

A news entry isn't necessary for this.

@d3r3kk
Copy link
Author

d3r3kk commented Jul 16, 2018

@DonJayamanne twas a correction to the documentation on building PTVS on the command line. Didn't think it warranted the PR body nor the NEWS file. I can adjust behaviour if you wish, but I made a call on the PR description + News file body being less than the sum total change to a .md file. 😁

@d3r3kk d3r3kk closed this Jul 16, 2018
@d3r3kk
Copy link
Author

d3r3kk commented Jul 16, 2018

Let's make sure this doc-only change builds!

@d3r3kk d3r3kk reopened this Jul 16, 2018
@d3r3kk d3r3kk merged commit b7cba8f into master Jul 18, 2018
@d3r3kk d3r3kk deleted the PTVS-instructions branch July 18, 2018 00:21
bschley pushed a commit to bschley/vscode-python that referenced this pull request Aug 2, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants