Add PT-BR translation of Quickopen command #1900
Conversation
acwoss
commented
Jun 7, 2018
|
|
Codecov Report
@@ Coverage Diff @@
## master #1900 +/- ##
==========================================
+ Coverage 74.42% 74.47% +0.04%
==========================================
Files 282 282
Lines 13260 13267 +7
Branches 2385 2386 +1
==========================================
+ Hits 9869 9880 +11
+ Misses 3260 3254 -6
- Partials 131 133 +2
Continue to review full report at Codecov.
|
|
I really liked the translation. My only suggestion is changing “teste unitário” to “teste de unidade”. I believe this translates better to Portuguese since we are testing a unit instead of executing a single test for everything. I know some literature has it wrongly translated (as many other classical wrong Brazilian translations in software) so I understand if kept the way it is. Congratulations for pull request. |
There was a problem hiding this comment.
Great translation! :) Only some minor suggestions, but it is pretty good in the over all.
I would suggest to keep using only one translation of workspace to avoid confusion.
Here it is being used Espaço de Trabalho and here we have Área de Trabalho. This is a tricky translation for pt-BR actually, because Área de Trabalho may sounds like Desktop for us. So I would suggest to use Espaço de Trabalho.
package.nls.pt-br.json
Outdated
| "python.command.python.startREPL.title": "Iniciar REPL", | ||
| "python.command.python.createTerminal.title": "Criar Terminal", | ||
| "python.command.python.buildWorkspaceSymbols.title": "Construir Símbolos da Área de Trabalho", | ||
| "python.command.python.runtests.title": "Executar Todos Testes Unitários", |
There was a problem hiding this comment.
I would add an article here:
Executar Todos os Testes Unitários
And the same for the line bellow
Depurar Todos os Testes Unitários
There was a problem hiding this comment.
I agree that "Espaço de Trabalho" would be a better translation for "Workspace", but it seems that VS Code has already adopted "Área de Trabalho" as default elsewhere and I have chosen to use it for consistency. About using "Espaço de Trabalho", my fault.
|
@acwoss does the comment from @ppcmiranda need to still be addressed? Let me know as I'm ready to merge this when you give us the go-ahead. |
|
@brettcannonYes, it's okay to merge. |
|
Thanks everyone for this! |